Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: content/gpu/gpu_main.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/gpu/gpu_main.cc
diff --git a/content/gpu/gpu_main.cc b/content/gpu/gpu_main.cc
index 782063850427efdd0cf34c0f7fec0c98d5e2e4ef..8606afe82cfcceec27584151bfc436b8bab76956 100644
--- a/content/gpu/gpu_main.cc
+++ b/content/gpu/gpu_main.cc
@@ -540,13 +540,6 @@ bool StartSandboxWindows(const sandbox::SandboxInterfaceInfo* sandbox_info) {
// content.
sandbox::TargetServices* target_services = sandbox_info->target_services;
if (target_services) {
-#if defined(ADDRESS_SANITIZER)
- // Bind and leak dbghelp.dll before the token is lowered, otherwise
- // AddressSanitizer will crash when trying to symbolize a report.
- if (!LoadLibraryA("dbghelp.dll"))
- return false;
-#endif
-
target_services->LowerToken();
return true;
}

Powered by Google App Engine
This is Rietveld 408576698