Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Unified Diff: content/common/sandbox_linux/sandbox_linux.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/sandbox_linux/sandbox_linux.cc
diff --git a/content/common/sandbox_linux/sandbox_linux.cc b/content/common/sandbox_linux/sandbox_linux.cc
index 952772ee648634f796e2aa4879461709a50ea69b..15472c39d91bc02383115612fe06ba02bb04c16c 100644
--- a/content/common/sandbox_linux/sandbox_linux.cc
+++ b/content/common/sandbox_linux/sandbox_linux.cc
@@ -140,13 +140,6 @@ void LinuxSandbox::PreinitializeSandbox() {
sanitizer_args_.reset();
#endif
-#if !defined(NDEBUG) || (defined(CFI_ENFORCEMENT) && !defined(OFFICIAL_BUILD))
- // The in-process stack dumping needs to open /proc/self/maps and cache
- // its contents before the sandbox is enabled. It also pre-opens the
- // object files that are already loaded in the process address space.
- base::debug::EnableInProcessStackDumpingForSandbox();
-#endif // !defined(NDEBUG)
-
// Open proc_fd_. It would break the security of the setuid sandbox if it was
// not closed.
// If LinuxSandbox::PreinitializeSandbox() runs, InitializeSandbox() must run

Powered by Google App Engine
This is Rietveld 408576698