components/nacl/loader/nacl_helper_win_64.cc - Issue 1291553003: Print stack traces in child processes when browser tests failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/nacl/loader/nacl_helper_win_64.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/nacl/loader/nacl_helper_win_64.cc

diff --git a/components/nacl/loader/nacl_helper_win_64.cc b/components/nacl/loader/nacl_helper_win_64.cc

index d67b7b32715fdce43920b87aa012236bd3b9e4f1..91bb8ce126ede029acfe3980799cc1ad311e39be 100644

--- a/components/nacl/loader/nacl_helper_win_64.cc

+++ b/components/nacl/loader/nacl_helper_win_64.cc

@@ -61,7 +61,7 @@ int NaClWin64Main() {

content::SetupCRT(command_line);

// Route stdio to parent console (if any) or create one.

if (command_line.HasSwitch(switches::kEnableLogging))

- base::RouteStdioToConsole();

+ base::RouteStdioToConsole(true);

// Initialize the sandbox for this process.

bool sandbox_initialized_ok = content::InitializeSandbox(&sandbox_info);

« base/debug/stack_trace_win.cc ('K') | « base/test/test_suite.cc ('k') | components/nacl/loader/nacl_main_platform_delegate_win.cc » ('j') | content/app/content_main_runner.cc » ('J')