Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: components/nacl/loader/nacl_main_platform_delegate_win.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/loader/nacl_main_platform_delegate_win.cc
diff --git a/components/nacl/loader/nacl_main_platform_delegate_win.cc b/components/nacl/loader/nacl_main_platform_delegate_win.cc
index 268113816c2e5df2f3e10c8945aecedf0d3a841d..e4d0ad5520d6cf2e9e7dca62fa10a440310278f4 100644
--- a/components/nacl/loader/nacl_main_platform_delegate_win.cc
+++ b/components/nacl/loader/nacl_main_platform_delegate_win.cc
@@ -21,12 +21,6 @@ void NaClMainPlatformDelegate::EnableSandbox(
::GetUserDefaultLangID();
::GetUserDefaultLCID();
-#if defined(ADDRESS_SANITIZER)
- // Bind and leak dbghelp.dll before the token is lowered, otherwise
- // AddressSanitizer will crash when trying to symbolize a report.
- CHECK(LoadLibraryA("dbghelp.dll"));
-#endif
-
// Turn the sandbox on.
target_services->LowerToken();
}

Powered by Google App Engine
This is Rietveld 408576698