base/test/test_suite.cc - Issue 1291553003: Print stack traces in child processes when browser tests failed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/test/test_suite.cc

Issue 1291553003: Print stack traces in child processes when browser tests failed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: patch 1295823002 which fixes the console coming up on Win8+ and adds regression tests Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: base/test/test_suite.cc

diff --git a/base/test/test_suite.cc b/base/test/test_suite.cc

index 2910466f3e99edbada8cdbef35386d5c3e87990e..fee7b6879505ef326bce200dccd5e046b4165896 100644

--- a/base/test/test_suite.cc

+++ b/base/test/test_suite.cc

@@ -17,6 +17,7 @@

#include "base/logging.h"

#include "base/memory/scoped_ptr.h"

#include "base/path_service.h"

+#include "base/process/launch.h"

#include "base/process/memory.h"

#include "base/test/gtest_xml_unittest_result_printer.h"

#include "base/test/gtest_xml_util.h"

@@ -312,6 +313,7 @@ void TestSuite::Initialize() {

CHECK(debug::EnableInProcessStackDumping());

#if defined(OS_WIN)

+ RouteStdioToConsole(true);

// Make sure we run with high resolution timer to minimize differences

// between production code and test code.

Time::EnableHighResolutionTimer(true);

« base/debug/stack_trace_win.cc ('K') | « base/process/launch_win.cc ('k') | components/nacl/loader/nacl_helper_win_64.cc » ('j') | content/app/content_main_runner.cc » ('J')