Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance (Closed)

Created:
5 years, 4 months ago by droger
Modified:
5 years, 4 months ago
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@webResources1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Inject JSON parsing in WebResource as a callback rather than inheritance This CL replaces inheritance by composition to inject the JSON parsing behavior. It deletes the subclasses ChromeWebResourceService and IOWebResourceService, and introduces web_resource::ParseJSONCallback instead. BUG=371477 TBR=jochen Committed: https://crrev.com/73a6070e3cf6180e4b0f1b003605fdaf5586dbfa Cr-Commit-Position: refs/heads/master@{#345286}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -246 lines) Patch
M chrome/browser/browser_process_impl.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugins_resource_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/plugins/plugins_resource_service.cc View 2 chunks +13 lines, -7 lines 0 comments Download
D chrome/browser/web_resource/chrome_web_resource_service.h View 1 chunk +0 lines, -34 lines 0 comments Download
D chrome/browser/web_resource/chrome_web_resource_service.cc View 1 chunk +0 lines, -42 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.h View 3 chunks +8 lines, -3 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service.cc View 1 chunk +17 lines, -8 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/web_resource/promo_resource_service_unittest.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M components/web_resource/web_resource_service.h View 5 chunks +12 lines, -11 lines 0 comments Download
M components/web_resource/web_resource_service.cc View 3 chunks +10 lines, -6 lines 0 comments Download
D ios/chrome/browser/web_resource/ios_web_resource_service.h View 1 chunk +0 lines, -44 lines 0 comments Download
D ios/chrome/browser/web_resource/ios_web_resource_service.cc View 1 chunk +0 lines, -78 lines 0 comments Download
M ios/chrome/ios_chrome.gyp View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
droger
5 years, 4 months ago (2015-08-24 15:25:12 UTC) #8
Robert Sesek
LGTM. Nice cleanup!
5 years, 4 months ago (2015-08-24 18:33:23 UTC) #9
droger
Thanks for the review. TBR jochen for callsite changes in: chrome/browser/browser_process_impl.cc chrome/browser/plugins/plugins_resource_service.cc chrome/browser/plugins/plugins_resource_service.h
5 years, 4 months ago (2015-08-25 08:04:25 UTC) #11
droger
5 years, 4 months ago (2015-08-25 08:05:03 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291543004/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291543004/120001
5 years, 4 months ago (2015-08-25 08:05:24 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:120001)
5 years, 4 months ago (2015-08-25 08:45:27 UTC) #15
commit-bot: I haz the power
5 years, 4 months ago (2015-08-25 08:46:02 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/73a6070e3cf6180e4b0f1b003605fdaf5586dbfa
Cr-Commit-Position: refs/heads/master@{#345286}

Powered by Google App Engine
This is Rietveld 408576698