chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc - Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc

Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webResources1

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/web_resource/promo_resource_service.cc ('k') | chrome/browser/web_resource/promo_resource_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc

diff --git a/chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc b/chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc

index 2cde97df38f4d10919c1f27b43f551ed5d35ee4e..c88d9e7a95bcf0eb2f8339a0a09191be6597f188 100644

--- a/chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc

+++ b/chrome/browser/web_resource/promo_resource_service_mobile_ntp_unittest.cc

@@ -25,8 +25,9 @@ class PromoResourceServiceMobileNtpTest : public testing::Test {

public:

PromoResourceServiceMobileNtpTest() {

NotificationPromo::RegisterPrefs(local_state_.registry());

- promo_resource_service_.reset(

- new PromoResourceService(&local_state_, kChannel));

+ promo_resource_service_.reset(new PromoResourceService(

+ &local_state_, kChannel, "en", nullptr, nullptr,

+ web_resource::WebResourceService::ParseJSONCallback()));

}

protected: