Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: ios/chrome/browser/web_resource/ios_web_resource_service.h

Issue 1291543004: Inject JSON parsing in WebResource as a callback rather than inheritance (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@webResources1
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/web_resource/ios_web_resource_service.h
diff --git a/ios/chrome/browser/web_resource/ios_web_resource_service.h b/ios/chrome/browser/web_resource/ios_web_resource_service.h
deleted file mode 100644
index fda5ec968f4a1bc6ab1a734ab4cf17672a675169..0000000000000000000000000000000000000000
--- a/ios/chrome/browser/web_resource/ios_web_resource_service.h
+++ /dev/null
@@ -1,44 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef IOS_CHROME_BROWSER_WEB_RESOURCE_IOS_WEB_RESOURCE_SERVICE_H_
-#define IOS_CHROME_BROWSER_WEB_RESOURCE_IOS_WEB_RESOURCE_SERVICE_H_
-
-#include <string>
-
-#include "base/macros.h"
-#include "base/memory/scoped_ptr.h"
-#include "components/web_resource/web_resource_service.h"
-
-// iOS implementation of WebResourceService.
-// IOSWebResourceService does not parses JSON out of process, because of
-// platform limitations.
-class IOSWebResourceService : public web_resource::WebResourceService {
- public:
- IOSWebResourceService(PrefService* prefs,
- const GURL& web_resource_server,
- bool apply_locale_to_url,
- const char* last_update_time_pref_name,
- int start_fetch_delay_ms,
- int cache_update_delay_ms);
-
- protected:
- ~IOSWebResourceService() override;
-
- private:
- // Parses JSON in a background thread.
- static base::Closure ParseJSONOnBackgroundThread(
- const std::string& data,
- const SuccessCallback& success_callback,
- const ErrorCallback& error_callback);
-
- // WebResourceService implementation:
- void ParseJSON(const std::string& data,
- const SuccessCallback& success_callback,
- const ErrorCallback& error_callback) override;
-
- DISALLOW_COPY_AND_ASSIGN(IOSWebResourceService);
-};
-
-#endif // IOS_CHROME_BROWSER_WEB_RESOURCE_IOS_WEB_RESOURCE_SERVICE_H_
« no previous file with comments | « components/web_resource/web_resource_service.cc ('k') | ios/chrome/browser/web_resource/ios_web_resource_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698