Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(719)

Issue 129153002: Make V8ValueConverterImpl serialize objects with internal field counts to an (Closed)

Created:
6 years, 11 months ago by not at google - send to devlin
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Make V8ValueConverterImpl serialize objects with internal field counts to an empty object rather than skipping them altogether. This is more consistent with the expected behaviour of extension APIs. BUG=330559 R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243972

Patch Set 1 #

Patch Set 2 : update test expectation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M chrome/test/data/extensions/api_test/executescript/callback/test.js View 1 2 chunks +5 lines, -4 lines 0 comments Download
M content/renderer/v8_value_converter_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
not at google - send to devlin
6 years, 11 months ago (2014-01-08 21:08:02 UTC) #1
jochen (gone - plz use gerrit)
the bots disagree :)
6 years, 11 months ago (2014-01-09 08:02:57 UTC) #2
not at google - send to devlin
Cool, I've updated test expectations.
6 years, 11 months ago (2014-01-09 16:14:32 UTC) #3
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-09 16:15:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/129153002/240001
6 years, 11 months ago (2014-01-09 16:16:32 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=244179
6 years, 11 months ago (2014-01-09 19:18:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/129153002/240001
6 years, 11 months ago (2014-01-09 19:32:25 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 21:05:43 UTC) #8
Message was sent while issue was closed.
Change committed as 243972

Powered by Google App Engine
This is Rietveld 408576698