Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5589)

Unified Diff: chrome/test/data/extensions/api_test/executescript/callback/test.js

Issue 129153002: Make V8ValueConverterImpl serialize objects with internal field counts to an (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: update test expectation Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/renderer/v8_value_converter_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/extensions/api_test/executescript/callback/test.js
diff --git a/chrome/test/data/extensions/api_test/executescript/callback/test.js b/chrome/test/data/extensions/api_test/executescript/callback/test.js
index 5f141baf9289256cc121e2dcaba34cf1bd0fc738..f9091ef3a62a90cf7a6bf8ecbb0e04b89900c837 100644
--- a/chrome/test/data/extensions/api_test/executescript/callback/test.js
+++ b/chrome/test/data/extensions/api_test/executescript/callback/test.js
@@ -86,9 +86,10 @@ chrome.test.getConfig(function(config) {
});
},
- // DOM objects (nodes, properties, etc) should not get converted. We
- // could try to convert them the best they can but it's undefined what
- // that means.
+ // DOM objects (nodes, properties, etc) should be converted to empty
+ // objects. We could try to convert them the best they can but it's
+ // undefined what that means. Ideally it'd just throw an exception but
+ // the backwards compatible ship sailed long ago.
function executeCallbackDOMObjShouldSucceedAndReturnNull() {
[ 'document',
'document.getElementById("testDiv")',
@@ -99,7 +100,7 @@ chrome.test.getConfig(function(config) {
chrome.tabs.executeScript(tabId,
{code: 'var obj = ' + expr + '; obj'},
chrome.test.callbackPass(function(result) {
- chrome.test.assertEq([null], result, 'Failed for ' + expr);
+ chrome.test.assertEq([{}], result, 'Failed for ' + expr);
}));
});
},
« no previous file with comments | « no previous file | content/renderer/v8_value_converter_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698