Make V8ValueConverterImpl serialize objects with internal field counts to an

content/renderer/v8_value_converter_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/v8_value_converter_impl.h"
 
 #include <string>
 
 #include "base/float_util.h"
 #include "base/logging.h"
@@ skipping 388 matching lines @@
   // Don't consider DOM objects. This check matches isHostObject() in Blink's
   // bindings/v8/V8Binding.h used in structured cloning. It reads:
   //
   // If the object has any internal fields, then we won't be able to serialize
   // or deserialize them; conveniently, this is also a quick way to detect DOM
   // wrapper objects, because the mechanism for these relies on data stored in
   // these fields.
   //
   // NOTE: check this after |strategy_| so that callers have a chance to
   // do something else, such as convert to the node's name rather than NULL.
+  //
+  // ANOTHER NOTE: returning an empty dictionary here to minimise surprise.
+  // See also http://crbug.com/330559.
   if (val->InternalFieldCount())
-    return NULL;
+    return new base::DictionaryValue();
 
   scoped_ptr<base::DictionaryValue> result(new base::DictionaryValue());
   v8::Handle<v8::Array> property_names(val->GetOwnPropertyNames());
 
   for (uint32 i = 0; i < property_names->Length(); ++i) {
     v8::Handle<v8::Value> key(property_names->Get(i));
 
     // Extend this test to cover more types as necessary and if sensible.
     if (!key->IsString() &&
         !key->IsNumber()) {
@@ skipping 43 matching lines @@
       continue;
 
     result->SetWithoutPathExpansion(std::string(*name_utf8, name_utf8.length()),
                                     child.release());
   }
 
   return result.release();
 }
 
 }  // namespace content