Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1290803002: Remove STATIC_CONST_MEMBER_DEFINITION. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
pdr.
CC:
blink-reviews, blink-reviews-style_chromium.org, Peter Kasting
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

Remove STATIC_CONST_MEMBER_DEFINITION. See https://codereview.chromium.org/1291623002/ for the reasoning. Also allow kFooBar names in enums. BUG=none Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200613

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -14 lines) Patch
M Source/config.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/platform/SharedBuffer.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/SharedBuffer.cpp View 1 2 3 chunks +2 lines, -4 lines 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp.py View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Nico
(pkasting: FYI, this patch shows a real disadvantage of using enums: Even though they decay ...
5 years, 4 months ago (2015-08-15 17:32:06 UTC) #2
pdr.
LGTM
5 years, 4 months ago (2015-08-15 20:09:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290803002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290803002/40001
5 years, 4 months ago (2015-08-15 20:09:49 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 22:16:16 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200613

Powered by Google App Engine
This is Rietveld 408576698