Tools/Scripts/webkitpy/style/checkers/cpp.py - Issue 1290803002: Remove STATIC_CONST_MEMBER_DEFINITION.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Tools/Scripts/webkitpy/style/checkers/cpp.py

Issue 1290803002: Remove STATIC_CONST_MEMBER_DEFINITION. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: . Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Tools/Scripts/webkitpy/style/checkers/cpp.py

diff --git a/Tools/Scripts/webkitpy/style/checkers/cpp.py b/Tools/Scripts/webkitpy/style/checkers/cpp.py

index bac6adce8d3850446e65e5cb1d9007ff559b3849..232ab386a294298bacf854589c1531eebb9a45ea 100644

--- a/Tools/Scripts/webkitpy/style/checkers/cpp.py

+++ b/Tools/Scripts/webkitpy/style/checkers/cpp.py

@@ -1269,7 +1269,7 @@ class _EnumState(object):

# and identifiers for the value of the enumerator, but do not accept any other constant

# expressions. However, this is sufficient for now (11/27/2012).

expr_all_uppercase = r'\s*[A-Z0-9_]+\s*(?:=\s*[a-zA-Z0-9]+\s*)?,?\s*$'

- expr_starts_lowercase = r'\s*[a-z]'

+ expr_starts_lowercase = r'\s*[a-jl-z]|k[a-z]'

expr_enum_end = r'}\s*(?:[a-zA-Z0-9]+\s*(?:=\s*[a-zA-Z0-9]+)?)?\s*;\s*'

expr_enum_start = r'\s*enum(?:\s+[a-zA-Z0-9]+)?\s*\{?\s*'

if self.in_enum_decl: