Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Side by Side Diff: Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py

Issue 1290803002: Remove STATIC_CONST_MEMBER_DEFINITION. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: . Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # -*- coding: utf-8; -*- 1 # -*- coding: utf-8; -*-
2 # 2 #
3 # Copyright (C) 2011 Google Inc. All rights reserved. 3 # Copyright (C) 2011 Google Inc. All rights reserved.
4 # Copyright (C) 2009 Torch Mobile Inc. 4 # Copyright (C) 2009 Torch Mobile Inc.
5 # Copyright (C) 2009 Apple Inc. All rights reserved. 5 # Copyright (C) 2009 Apple Inc. All rights reserved.
6 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org) 6 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
7 # 7 #
8 # Redistribution and use in source and binary forms, with or without 8 # Redistribution and use in source and binary forms, with or without
9 # modification, are permitted provided that the following conditions are 9 # modification, are permitted provided that the following conditions are
10 # met: 10 # met:
(...skipping 3421 matching lines...) Expand 10 before | Expand all | Expand 10 after
3432 enum Foo { 3432 enum Foo {
3433 fooOne = 1, 3433 fooOne = 1,
3434 FooTwo = 2 3434 FooTwo = 2
3435 };''', 3435 };''',
3436 'enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]') 3436 'enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4]')
3437 3437
3438 self.assert_multi_line_lint( 3438 self.assert_multi_line_lint(
3439 '''\ 3439 '''\
3440 enum Foo { 3440 enum Foo {
3441 FooOne = 1, 3441 FooOne = 1,
3442 FooTwo 3442 FooTwo,
3443 kFooConst,
3443 } fooVar = FooOne; 3444 } fooVar = FooOne;
3444 enum { FooOne, FooTwo }; 3445 enum { FooOne, FooTwo };
3445 enum { FooOne, FooTwo } fooVar = FooTwo; 3446 enum { FooOne, FooTwo } fooVar = FooTwo;
3446 enum { FooOne= FooTwo } foo; 3447 enum { FooOne= FooTwo } foo;
3447 enum Enum123 { 3448 enum Enum123 {
3448 FooOne, 3449 FooOne,
3449 FooTwo = FooOne, 3450 FooTwo = FooOne,
3450 };''', 3451 };''',
3451 '') 3452 '')
3452 3453
(...skipping 1778 matching lines...) Expand 10 before | Expand all | Expand 10 after
5231 def test_ne(self): 5232 def test_ne(self):
5232 """Test __ne__ inequality function.""" 5233 """Test __ne__ inequality function."""
5233 checker1 = self._checker() 5234 checker1 = self._checker()
5234 checker2 = self._checker() 5235 checker2 = self._checker()
5235 5236
5236 # != calls __ne__. 5237 # != calls __ne__.
5237 # By default, __ne__ always returns true on different objects. 5238 # By default, __ne__ always returns true on different objects.
5238 # Thus, just check the distinguishing case to verify that the 5239 # Thus, just check the distinguishing case to verify that the
5239 # code defines __ne__. 5240 # code defines __ne__.
5240 self.assertFalse(checker1 != checker2) 5241 self.assertFalse(checker1 != checker2)
OLDNEW
« no previous file with comments | « Tools/Scripts/webkitpy/style/checkers/cpp.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698