Source/core/dom/DocumentTiming.h - Issue 1290683003: Remove WeakPtrs from DocumentTiming/DocumentLoadTiming

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/DocumentTiming.h

Issue 1290683003: Remove WeakPtrs from DocumentTiming/DocumentLoadTiming (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/DocumentTiming.h

diff --git a/Source/core/dom/DocumentTiming.h b/Source/core/dom/DocumentTiming.h

index 6cc1a8c59966d4121ae92593dfb82e87beb41693..5c2f9ca2802092ba1e478d1a1eb0d32dacad7df6 100644

--- a/Source/core/dom/DocumentTiming.h

+++ b/Source/core/dom/DocumentTiming.h

@@ -35,7 +35,7 @@ class Document;

class DocumentTiming final {

DISALLOW_ALLOCATION();

public:

- DocumentTiming(WeakPtrWillBeRawPtr<Document>);

+ DocumentTiming(RawPtrWillBeMember<Document>);

sof 2015/08/18 19:13:48 Make this explicit DocumentTiming(Document&);

void markDomLoading();

void markDomInteractive();

@@ -63,7 +63,7 @@ private:

double m_domComplete;

double m_firstLayout;

- WeakPtrWillBeMember<Document> m_document;

+ RawPtrWillBeMember<Document> m_document;

};

}

« Source/core/dom/Document.cpp ('K') | « Source/core/dom/Document.cpp ('k') | Source/core/dom/DocumentTiming.cpp » ('j') | Source/core/loader/DocumentLoadTiming.h » ('J')