Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1075)

Issue 1290063002: Debugger: do not expose global object. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: do not expose global object. Committed: https://crrev.com/f9a3e6a6aacd53f13a1571a55bbb066b223295ff Cr-Commit-Position: refs/heads/master@{#30149}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M src/debug/debug-scopes.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/runtime/runtime-debug.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (4 generated)
Yang
This is necessary for https://codereview.chromium.org/1287243002, because we can't use global objects as map keys.
5 years, 4 months ago (2015-08-13 08:19:46 UTC) #2
Benedikt Meurer
lgtm
5 years, 4 months ago (2015-08-13 08:20:28 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290063002/1
5 years, 4 months ago (2015-08-13 09:21:46 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-13 10:16:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1290063002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1290063002/1
5 years, 4 months ago (2015-08-13 10:18:11 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 10:20:00 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 10:20:12 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f9a3e6a6aacd53f13a1571a55bbb066b223295ff
Cr-Commit-Position: refs/heads/master@{#30149}

Powered by Google App Engine
This is Rietveld 408576698