Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issue 1287243002: Debugger: use a Map to cache mirrors. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev, Yang, yurys
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: use a Map to cache mirrors. This makes mirror cache lookup O(1) instead of O(n). The downside is that the lookup via handle is O(n). This is fine because handles are only used in the JSON api, which is not used by Chrome and on death row. Committed: https://crrev.com/890b1dfca84d9dfecdcfc56517ef541076c6eb1d Cr-Commit-Position: refs/heads/master@{#30150}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -28 lines) Patch
M src/bootstrapper.cc View 2 chunks +11 lines, -12 lines 0 comments Download
M src/debug/mirrors.js View 6 chunks +10 lines, -16 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Yang
5 years, 4 months ago (2015-08-13 08:20:42 UTC) #2
Benedikt Meurer
LGTM.
5 years, 4 months ago (2015-08-13 08:51:59 UTC) #3
Yang
FYI yurys@
5 years, 4 months ago (2015-08-13 09:54:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287243002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287243002/1
5 years, 4 months ago (2015-08-13 10:21:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-13 10:49:10 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/890b1dfca84d9dfecdcfc56517ef541076c6eb1d Cr-Commit-Position: refs/heads/master@{#30150}
5 years, 4 months ago (2015-08-13 10:49:25 UTC) #8
Yang
5 years, 4 months ago (2015-08-13 12:09:17 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1292023002/ by yangguo@chromium.org.

The reason for reverting is: Several nosnap and custom snapshot failures..

Powered by Google App Engine
This is Rietveld 408576698