Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291043002: Debugger: remove duplicate heap iterations. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@debuggerglobal
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Debugger: remove duplicate heap iterations. R=mlippautz@chromium.org Committed: https://crrev.com/fe4d8e285b9c36b03846617b85e55f513856e56f Cr-Commit-Position: refs/heads/master@{#30162}

Patch Set 1 #

Patch Set 2 : slight change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -234 lines) Patch
M src/debug/liveedit.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/debug/liveedit.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M src/objects.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects.cc View 1 1 chunk +10 lines, -0 lines 0 comments Download
M src/runtime/runtime-debug.cc View 1 3 chunks +54 lines, -158 lines 0 comments Download
M src/runtime/runtime-liveedit.cc View 2 chunks +19 lines, -48 lines 0 comments Download
M src/runtime/runtime-object.cc View 1 1 chunk +4 lines, -9 lines 0 comments Download

Depends on Patchset:

Issue 1290063002 Patch 1

Messages

Total messages: 6 (1 generated)
Yang
Please take a look. This simplifies some debugger code without changing the functionality.
5 years, 4 months ago (2015-08-13 09:46:51 UTC) #1
Michael Lippautz
lgtm
5 years, 4 months ago (2015-08-13 15:41:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291043002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291043002/20001
5 years, 4 months ago (2015-08-13 16:01:36 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-13 16:26:08 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 16:26:31 UTC) #6
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/fe4d8e285b9c36b03846617b85e55f513856e56f
Cr-Commit-Position: refs/heads/master@{#30162}

Powered by Google App Engine
This is Rietveld 408576698