Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Issue 1289753005: ServiceWorker webexposed tests should skip JS builtins (Closed)

Created:
5 years, 4 months ago by adamk
Modified:
5 years, 4 months ago
Reviewers:
jsbell, ojan
CC:
blink-reviews, falken, horo+watch_chromium.org, jochen (gone - plz use gerrit), jsbell+serviceworker_chromium.org, kenjibaheux+watch_chromium.org, kinuko+serviceworker, michaeln, nhiroki, serviceworker-reviews, tzik
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

ServiceWorker webexposed tests should skip JS builtins This makes the ServiceWorker version of this test match all the other versions of this test, which have skipped JS builtins since https://src.chromium.org/viewvc/blink?view=rev&revision=198071 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200511

Patch Set 1 #

Total comments: 2

Messages

Total messages: 8 (3 generated)
adamk
5 years, 4 months ago (2015-08-13 22:18:54 UTC) #2
ojan
lgtm https://codereview.chromium.org/1289753005/diff/1/LayoutTests/webexposed/resources/global-interface-listing.js File LayoutTests/webexposed/resources/global-interface-listing.js (right): https://codereview.chromium.org/1289753005/diff/1/LayoutTests/webexposed/resources/global-interface-listing.js#newcode31 LayoutTests/webexposed/resources/global-interface-listing.js:31: // LayoutTests/http/tests/serviceworker/webexposed/resources/global-interface-listing-worker.js If only we had modules we ...
5 years, 4 months ago (2015-08-13 22:29:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289753005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289753005/1
5 years, 4 months ago (2015-08-13 22:30:16 UTC) #5
jsbell
https://codereview.chromium.org/1289753005/diff/1/LayoutTests/webexposed/resources/global-interface-listing.js File LayoutTests/webexposed/resources/global-interface-listing.js (right): https://codereview.chromium.org/1289753005/diff/1/LayoutTests/webexposed/resources/global-interface-listing.js#newcode31 LayoutTests/webexposed/resources/global-interface-listing.js:31: // LayoutTests/http/tests/serviceworker/webexposed/resources/global-interface-listing-worker.js If we could align the files there's ...
5 years, 4 months ago (2015-08-13 23:27:23 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 02:02:12 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200511

Powered by Google App Engine
This is Rietveld 408576698