Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Unified Diff: LayoutTests/webexposed/resources/global-interface-listing.js

Issue 1289753005: ServiceWorker webexposed tests should skip JS builtins (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webexposed/resources/global-interface-listing.js
diff --git a/LayoutTests/webexposed/resources/global-interface-listing.js b/LayoutTests/webexposed/resources/global-interface-listing.js
index fb1d41a3cc83e3fb26bb18727a78ff8bf678ed07..bd7da4fa2356648fa7f41edfc4fc936d17182e17 100644
--- a/LayoutTests/webexposed/resources/global-interface-listing.js
+++ b/LayoutTests/webexposed/resources/global-interface-listing.js
@@ -26,6 +26,9 @@ if (self.importScripts) {
// List of builtin JS constructors; Blink is not controlling what properties these
// objects have, so exercising them in a Blink test doesn't make sense.
+//
+// If new builtins are added, please update this list along with the one in
+// LayoutTests/http/tests/serviceworker/webexposed/resources/global-interface-listing-worker.js
ojan 2015/08/13 22:29:58 If only we had modules we could share this list! :
jsbell 2015/08/13 23:27:22 If we could align the files there's a PRESUBMIT in
var jsBuiltins = new Set([
'Array',
'ArrayBuffer',
« no previous file with comments | « LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698