Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289673008: Get rid of a redundant argument DOWNSTREAM from VisbileSelection constructor call sites (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
tkent
CC:
blink-reviews, je_julie, nektarios, dmazzoni, aboxhall, dcheng, yoichio
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Get rid of a redundant argument DOWNSTREAM from VisbileSelection constructor call sites This patch gets rid of a redundant argument DOWNSTREAM from |VisbileSelection| constructor call sites to simplify source code for improving code health, since default value of affinity is |DOWNSTREAM| in each constructor declarations. This patch is a preparation of introducing |TextAffinity| enum class as replacement of |EAffinity|, http://crbug.com/522038. BUG=522038 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200788

Patch Set 1 : 2015-08-19T10:28:45 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M Source/core/editing/VisibleSelection.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DragController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/FocusController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXLayoutObject.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 01:58:37 UTC) #2
tkent
lgtm
5 years, 4 months ago (2015-08-19 02:08:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289673008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289673008/1
5 years, 4 months ago (2015-08-19 02:08:16 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 03:17:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200788

Powered by Google App Engine
This is Rietveld 408576698