Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: Source/core/editing/commands/CompositeEditCommand.cpp

Issue 1289673008: Get rid of a redundant argument DOWNSTREAM from VisbileSelection constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T10:28:45 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/commands/CompositeEditCommand.cpp
diff --git a/Source/core/editing/commands/CompositeEditCommand.cpp b/Source/core/editing/commands/CompositeEditCommand.cpp
index 72de46aacb88b1b1d262ca0f97a7ffbd0770f80a..eb8157f1570fbd1d3ca55a8af9637070083ff1c4 100644
--- a/Source/core/editing/commands/CompositeEditCommand.cpp
+++ b/Source/core/editing/commands/CompositeEditCommand.cpp
@@ -1142,7 +1142,7 @@ void CompositeEditCommand::moveParagraphWithClones(const VisiblePosition& startO
cloneParagraphUnderNewElement(start, end, outerNode, blockElement);
- setEndingSelection(VisibleSelection(start, end, DOWNSTREAM));
+ setEndingSelection(VisibleSelection(start, end));
deleteSelection(false, false, false);
// There are bugs in deletion when it removes a fully selected table/list.
@@ -1231,7 +1231,7 @@ void CompositeEditCommand::moveParagraphs(const VisiblePosition& startOfParagrap
// FIXME (5098931): We should add a new insert action "WebViewInsertActionMoved" and call shouldInsertFragment here.
- setEndingSelection(VisibleSelection(start, end, DOWNSTREAM));
+ setEndingSelection(VisibleSelection(start, end));
document().frame()->spellChecker().clearMisspellingsAndBadGrammar(endingSelection());
deleteSelection(false, false, false);
« no previous file with comments | « Source/core/editing/VisibleSelection.cpp ('k') | Source/core/page/DragController.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698