Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Side by Side Diff: Source/core/editing/VisibleSelection.cpp

Issue 1289673008: Get rid of a redundant argument DOWNSTREAM from VisbileSelection constructor call sites (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T10:28:45 Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved. 2 * Copyright (C) 2004, 2005, 2006 Apple Computer, Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 119 matching lines...) Expand 10 before | Expand all | Expand 10 after
130 #if !ENABLE(OILPAN) 130 #if !ENABLE(OILPAN)
131 VisibleSelection::~VisibleSelection() 131 VisibleSelection::~VisibleSelection()
132 { 132 {
133 didChange(); 133 didChange();
134 } 134 }
135 #endif 135 #endif
136 136
137 VisibleSelection VisibleSelection::selectionFromContentsOfNode(Node* node) 137 VisibleSelection VisibleSelection::selectionFromContentsOfNode(Node* node)
138 { 138 {
139 ASSERT(!editingIgnoresContent(node)); 139 ASSERT(!editingIgnoresContent(node));
140 return VisibleSelection(firstPositionInNode(node), lastPositionInNode(node), DOWNSTREAM); 140 return VisibleSelection(firstPositionInNode(node), lastPositionInNode(node)) ;
141 } 141 }
142 142
143 SelectionType VisibleSelection::selectionTypeInComposedTree() const 143 SelectionType VisibleSelection::selectionTypeInComposedTree() const
144 { 144 {
145 return selectionType(m_startInComposedTree, m_endInComposedTree); 145 return selectionType(m_startInComposedTree, m_endInComposedTree);
146 } 146 }
147 147
148 void VisibleSelection::setBase(const Position& position) 148 void VisibleSelection::setBase(const Position& position)
149 { 149 {
150 Position oldBase = m_base; 150 Position oldBase = m_base;
(...skipping 1101 matching lines...) Expand 10 before | Expand all | Expand 10 after
1252 sel.showTreeForThis(); 1252 sel.showTreeForThis();
1253 } 1253 }
1254 1254
1255 void showTree(const blink::VisibleSelection* sel) 1255 void showTree(const blink::VisibleSelection* sel)
1256 { 1256 {
1257 if (sel) 1257 if (sel)
1258 sel->showTreeForThis(); 1258 sel->showTreeForThis();
1259 } 1259 }
1260 1260
1261 #endif 1261 #endif
OLDNEW
« no previous file with comments | « no previous file | Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698