Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Unified Diff: runtime/vm/dart_api_impl.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/dart_api_impl.cc
diff --git a/runtime/vm/dart_api_impl.cc b/runtime/vm/dart_api_impl.cc
index 151d669359707f99f0f6ffb86835f3d51c700b74..275c84e2aaf2093d1545a63be958e73d860f0641 100644
--- a/runtime/vm/dart_api_impl.cc
+++ b/runtime/vm/dart_api_impl.cc
@@ -4392,7 +4392,7 @@ DART_EXPORT Dart_Handle Dart_GetField(Dart_Handle container, Dart_Handle name) {
return Api::NewHandle(
isolate, DartEntry::InvokeFunction(getter, Object::empty_array()));
} else if (!field.IsNull()) {
- return Api::NewHandle(isolate, field.value());
+ return Api::NewHandle(isolate, field.StaticFieldValue());
} else {
return Api::NewError("%s: did not find static field '%s'.",
CURRENT_FUNC, field_name.ToCString());
@@ -4460,7 +4460,7 @@ DART_EXPORT Dart_Handle Dart_GetField(Dart_Handle container, Dart_Handle name) {
isolate, DartEntry::InvokeFunction(getter, Object::empty_array()));
}
if (!field.IsNull()) {
- return Api::NewHandle(isolate, field.value());
+ return Api::NewHandle(isolate, field.StaticFieldValue());
}
return Api::NewError("%s: did not find top-level variable '%s'.",
CURRENT_FUNC, field_name.ToCString());
@@ -4536,7 +4536,7 @@ DART_EXPORT Dart_Handle Dart_SetField(Dart_Handle container,
return Api::NewError("%s: cannot set final field '%s'.",
CURRENT_FUNC, field_name.ToCString());
} else {
- field.set_value(value_instance);
+ field.SetStaticFieldValue(value_instance);
return Api::Success();
}
} else {
@@ -4616,7 +4616,7 @@ DART_EXPORT Dart_Handle Dart_SetField(Dart_Handle container,
return Api::NewError("%s: cannot set final top-level variable '%s'.",
CURRENT_FUNC, field_name.ToCString());
}
- field.set_value(value_instance);
+ field.SetStaticFieldValue(value_instance);
return Api::Success();
}
return Api::NewError("%s: did not find top-level variable '%s'.",
@@ -5674,7 +5674,7 @@ DART_EXPORT Dart_Handle Dart_FinalizeLoading(bool complete_futures) {
const Field& dirty_bit = Field::Handle(isolate,
libmirrors.LookupLocalField(String::Handle(String::New("dirty"))));
ASSERT(!dirty_bit.IsNull() && dirty_bit.is_static());
- dirty_bit.set_value(Bool::True());
+ dirty_bit.SetStaticFieldValue(Bool::True());
if (complete_futures) {
const Library& corelib = Library::Handle(isolate, Library::CoreLibrary());

Powered by Google App Engine
This is Rietveld 408576698