Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel…

runtime/vm/dart_api_impl.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "include/dart_api.h"
 #include "include/dart_mirrors_api.h"
 #include "include/dart_native_api.h"
 
 #include "platform/assert.h"
 #include "vm/class_finalizer.h"
@@ skipping 4374 matching lines @@
       const String& getter_name =
           String::Handle(isolate, Field::GetterName(field_name));
       getter = cls.LookupStaticFunctionAllowPrivate(getter_name);
     }
 
     if (!getter.IsNull()) {
       // Invoke the getter and return the result.
       return Api::NewHandle(
           isolate, DartEntry::InvokeFunction(getter, Object::empty_array()));
     } else if (!field.IsNull()) {
-      return Api::NewHandle(isolate, field.value());
+      return Api::NewHandle(isolate, field.StaticFieldValue());
     } else {
       return Api::NewError("%s: did not find static field '%s'.",
                            CURRENT_FUNC, field_name.ToCString());
     }
 
   } else if (obj.IsInstance()) {
     // Every instance field has a getter Function.  Try to find the
     // getter in any superclass and use that function to access the
     // field.
     const Instance& instance = Instance::Cast(obj);
@@ skipping 47 matching lines @@
           String::Handle(isolate, Field::GetterName(field_name));
       getter = cls.LookupStaticFunctionAllowPrivate(getter_name);
     }
 
     if (!getter.IsNull()) {
       // Invoke the getter and return the result.
       return Api::NewHandle(
           isolate, DartEntry::InvokeFunction(getter, Object::empty_array()));
     }
     if (!field.IsNull()) {
-      return Api::NewHandle(isolate, field.value());
+      return Api::NewHandle(isolate, field.StaticFieldValue());
     }
     return Api::NewError("%s: did not find top-level variable '%s'.",
                          CURRENT_FUNC, field_name.ToCString());
 
   } else if (obj.IsError()) {
       return container;
   } else {
     return Api::NewError(
         "%s expects argument 'container' to be an object, type, or library.",
         CURRENT_FUNC);
@@ skipping 55 matching lines @@
       if (result.IsError()) {
         return Api::NewHandle(isolate, result.raw());
       } else {
         return Api::Success();
       }
     } else if (!field.IsNull()) {
       if (field.is_final()) {
         return Api::NewError("%s: cannot set final field '%s'.",
                              CURRENT_FUNC, field_name.ToCString());
       } else {
-        field.set_value(value_instance);
+        field.SetStaticFieldValue(value_instance);
         return Api::Success();
       }
     } else {
       return Api::NewError("%s: did not find static field '%s'.",
                            CURRENT_FUNC, field_name.ToCString());
     }
 
   } else if (obj.IsInstance()) {
     // Every instance field has a setter Function.  Try to find the
     // setter in any superclass and use that function to access the
@@ skipping 59 matching lines @@
       if (result.IsError()) {
         return Api::NewHandle(isolate, result.raw());
       }
       return Api::Success();
     }
     if (!field.IsNull()) {
       if (field.is_final()) {
         return Api::NewError("%s: cannot set final top-level variable '%s'.",
                              CURRENT_FUNC, field_name.ToCString());
       }
-      field.set_value(value_instance);
+      field.SetStaticFieldValue(value_instance);
       return Api::Success();
     }
     return Api::NewError("%s: did not find top-level variable '%s'.",
                          CURRENT_FUNC, field_name.ToCString());
 
   } else if (obj.IsError()) {
     return container;
   }
   return Api::NewError(
       "%s expects argument 'container' to be an object, type, or library.",
@@ skipping 1037 matching lines @@
   // The code that completes the futures (invoked below) may call into the
   // newly loaded code and trigger one of these breakpoints.
   isolate->debugger()->NotifyDoneLoading();
 
   // Notify mirrors that MirrorSystem.libraries needs to be recomputed.
   const Library& libmirrors =
       Library::Handle(isolate, Library::MirrorsLibrary());
   const Field& dirty_bit = Field::Handle(isolate,
       libmirrors.LookupLocalField(String::Handle(String::New("dirty"))));
   ASSERT(!dirty_bit.IsNull() && dirty_bit.is_static());
-  dirty_bit.set_value(Bool::True());
+  dirty_bit.SetStaticFieldValue(Bool::True());
 
   if (complete_futures) {
     const Library& corelib = Library::Handle(isolate, Library::CoreLibrary());
     const String& function_name =
         String::Handle(isolate, String::New("_completeDeferredLoads"));
     const Function& function =
         Function::Handle(isolate,
                          corelib.LookupFunctionAllowPrivate(function_name));
     ASSERT(!function.IsNull());
     const Array& args = Array::empty_array();
@@ skipping 350 matching lines @@
   ASSERT(stream != NULL);
   TimelineEvent* event = stream->StartEvent();
   if (event != NULL) {
     event->AsyncEnd(label, async_id);
     event->Complete();
   }
   return Api::Success();
 }
 
 }  // namespace dart