runtime/vm/constant_propagator.cc - Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/constant_propagator.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: self-code-review Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/constant_propagator.cc

diff --git a/runtime/vm/constant_propagator.cc b/runtime/vm/constant_propagator.cc

index 29818e18b84761960977b4923b7949e1145842d4..b62800eb0a562987021ecda964779c125f21887e 100644

--- a/runtime/vm/constant_propagator.cc

+++ b/runtime/vm/constant_propagator.cc

@@ -706,7 +706,7 @@ void ConstantPropagator::VisitInitStaticField(InitStaticFieldInstr* instr) {

void ConstantPropagator::VisitLoadStaticField(LoadStaticFieldInstr* instr) {

const Field& field = instr->StaticField();

ASSERT(field.is_static());

- Instance& obj = Instance::Handle(I, field.value());

+ Instance& obj = Instance::Handle(I, field.StaticFieldValue());

if (field.is_final() && (obj.raw() != Object::sentinel().raw()) &&

(obj.raw() != Object::transition_sentinel().raw())) {

if (obj.IsSmi() || obj.IsOld()) {

« no previous file with comments | « runtime/vm/compiler.cc ('k') | runtime/vm/dart_api_impl.cc » ('j') | runtime/vm/flow_graph_builder.cc » ('J')