The value attribute should not be set for non-native text fields, according to HTML to Platform A11…

The value attribute should not be set for non-native text fields, according to HTML to Platform A11y Spec.

E.g. <div contenteditable<Some text.</div>. The node with role=SECTION should not have the value="Some text.".
This change should only be made for Windows and Linux but not the Mac because AXValue is used in non-native text fields, such as content editables.
BUG=491027
R=dmazzoni@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200758

[dmazzoni, 2015-08-18 06:14:17]

lgtm

Hmmm, I think you're right for Windows, but what about Mac? I'm worried that on
Mac we have to return all of the text content for a contenteditable to make it
behave like a text field.

OK if this doesn't actually regress behavior on Mac, please test.

[blink-reviews, 2015-08-18 17:56:14]

> Hmmm, I think you're right for Windows, but what about Mac? I'm 
> worried that on
> Mac we have to return all of the text content for a contenteditable to 
> make it
> behave like a text field.


I had already tested this with the existing browser test, that had been 
re-enabled in the other CL.
However, I also tested just now using a physical Mac and content 
editable in Gmail compose window works find. Simple text field also 
works fine.
I am not sure if this covers all the cases of content editable - Gmail 
uses role="textbox" on their content editable whilst other sites might 
not - but I'll submit and keep testing.

To unsubscribe from this group and stop receiving emails from it, send an email
to blink-reviews+unsubscribe@chromium.org.

[nektarios, 2015-08-18 17:57:22]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-08-18 17:57:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289103002/1

[commit-bot: I haz the power, 2015-08-18 20:49:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:49:25]

Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[nektarios, 2015-08-18 21:20:29]

The CQ bit was checked by nektar@chromium.org

[commit-bot: I haz the power, 2015-08-18 21:20:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289103002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289103002/1

[commit-bot: I haz the power, 2015-08-18 22:10:03]

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200758

[nektarios, 2015-08-21 01:47:23]

To clarify, this patch does not (and should not) affect the AXvalue attribute on
the Mac, as AXValue is required on that platform for reading the text in
non-native text fields, such as content editables.