Source/modules/accessibility/AXNodeObject.cpp - Issue 1289103002: The value attribute should not be set for non-native text fields, according to HTML to Platform A11…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1289103002: The value attribute should not be set for non-native text fields, according to HTML to Platform A11… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/accessibility/AXNodeObject.cpp

diff --git a/Source/modules/accessibility/AXNodeObject.cpp b/Source/modules/accessibility/AXNodeObject.cpp

index bbd7f0da421c4932053dac64c6e87b092400b731..cfcfebe740bbb6f41dce87390d396fc669706a28 100644

--- a/Source/modules/accessibility/AXNodeObject.cpp

+++ b/Source/modules/accessibility/AXNodeObject.cpp

@@ -1465,7 +1465,7 @@ String AXNodeObject::stringValue() const

return String();

}

- if (isTextControl())

+ if (isNativeTextControl())

return text();

// FIXME: We might need to implement a value here for more types

« no previous file with comments | « no previous file | no next file » | no next file with comments »