Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: Source/modules/accessibility/AXNodeObject.cpp

Issue 1289103002: The value attribute should not be set for non-native text fields, according to HTML to Platform A11… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012, Google Inc. All rights reserved. 2 * Copyright (C) 2012, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 1447 matching lines...) Expand 10 before | Expand all | Expand 10 after
1458 if (selectedIndex >= 0 && static_cast<size_t>(selectedIndex) < listItems .size()) { 1458 if (selectedIndex >= 0 && static_cast<size_t>(selectedIndex) < listItems .size()) {
1459 const AtomicString& overriddenDescription = listItems[selectedIndex] ->fastGetAttribute(aria_labelAttr); 1459 const AtomicString& overriddenDescription = listItems[selectedIndex] ->fastGetAttribute(aria_labelAttr);
1460 if (!overriddenDescription.isNull()) 1460 if (!overriddenDescription.isNull())
1461 return overriddenDescription; 1461 return overriddenDescription;
1462 } 1462 }
1463 if (!selectElement.multiple()) 1463 if (!selectElement.multiple())
1464 return selectElement.value(); 1464 return selectElement.value();
1465 return String(); 1465 return String();
1466 } 1466 }
1467 1467
1468 if (isTextControl()) 1468 if (isNativeTextControl())
1469 return text(); 1469 return text();
1470 1470
1471 // FIXME: We might need to implement a value here for more types 1471 // FIXME: We might need to implement a value here for more types
1472 // FIXME: It would be better not to advertise a value at all for the types f or which we don't implement one; 1472 // FIXME: It would be better not to advertise a value at all for the types f or which we don't implement one;
1473 // this would require subclassing or making accessibilityAttributeNames do s omething other than return a 1473 // this would require subclassing or making accessibilityAttributeNames do s omething other than return a
1474 // single static array. 1474 // single static array.
1475 return String(); 1475 return String();
1476 } 1476 }
1477 1477
1478 String AXNodeObject::ariaDescribedByAttribute() const 1478 String AXNodeObject::ariaDescribedByAttribute() const
(...skipping 970 matching lines...) Expand 10 before | Expand all | Expand 10 after
2449 return String(); 2449 return String();
2450 } 2450 }
2451 2451
2452 DEFINE_TRACE(AXNodeObject) 2452 DEFINE_TRACE(AXNodeObject)
2453 { 2453 {
2454 visitor->trace(m_node); 2454 visitor->trace(m_node);
2455 AXObject::trace(visitor); 2455 AXObject::trace(visitor);
2456 } 2456 }
2457 2457
2458 } // namespace blink 2458 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698