Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(675)

Issue 1288893004: Revert of Reland Call dispatcher's releaseRegistration when done with registrations (Closed)

Created:
5 years, 4 months ago by leviw_travelin_and_unemployed
Modified:
5 years, 4 months ago
Reviewers:
jkarlin, jsbell
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Revert of Reland Call dispatcher's releaseRegistration when done with registrations (patchset #2 id:40001 of https://codereview.chromium.org/1290073003/ ) Reason for revert: Speculatively reverting to fix crashes in http/tests/cache/cached-main-resource.html http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=http%2Ftests%2Fcache%2Fcached-main-resource.html Original issue's description: > Reland Call dispatcher's releaseRegistration when done with registrations > > Reland of https://codereview.chromium.org/1279323002/ > > OilPan objects can be garbage collected at any time, so it's necessary to check the pointers. > > BUG=502214 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200657 TBR=jsbell@chromium.org,jkarlin@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=502214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200663

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -27 lines) Patch
M Source/modules/background_sync/PeriodicSyncRegistration.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/modules/background_sync/SyncRegistration.cpp View 1 chunk +0 lines, -7 lines 0 comments Download
M public/platform/modules/background_sync/WebSyncProvider.h View 1 chunk +0 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
leviw_travelin_and_unemployed
Created Revert of Reland Call dispatcher's releaseRegistration when done with registrations
5 years, 4 months ago (2015-08-17 20:10:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288893004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288893004/1
5 years, 4 months ago (2015-08-17 20:10:56 UTC) #2
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 20:11:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200663

Powered by Google App Engine
This is Rietveld 408576698