Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: Source/modules/background_sync/SyncRegistration.cpp

Issue 1288893004: Revert of Reland Call dispatcher's releaseRegistration when done with registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/background_sync/SyncRegistration.h" 6 #include "modules/background_sync/SyncRegistration.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "core/dom/DOMException.h" 10 #include "core/dom/DOMException.h"
(...skipping 30 matching lines...) Expand all
41 41
42 SyncRegistration::SyncRegistration(int64_t id, const SyncRegistrationOptions& op tions, ServiceWorkerRegistration* serviceWorkerRegistration) 42 SyncRegistration::SyncRegistration(int64_t id, const SyncRegistrationOptions& op tions, ServiceWorkerRegistration* serviceWorkerRegistration)
43 : m_id(id) 43 : m_id(id)
44 , m_tag(options.tag()) 44 , m_tag(options.tag())
45 , m_serviceWorkerRegistration(serviceWorkerRegistration) 45 , m_serviceWorkerRegistration(serviceWorkerRegistration)
46 { 46 {
47 } 47 }
48 48
49 SyncRegistration::~SyncRegistration() 49 SyncRegistration::~SyncRegistration()
50 { 50 {
51 Platform* currentPlatform = Platform::current();
52 if (!currentPlatform)
53 return;
54 WebSyncProvider* syncProvider = currentPlatform->backgroundSyncProvider();
55 if (!syncProvider)
56 return;
57 syncProvider->releaseRegistration(m_id);
58 } 51 }
59 52
60 ScriptPromise SyncRegistration::done(ScriptState* scriptState) 53 ScriptPromise SyncRegistration::done(ScriptState* scriptState)
61 { 54 {
62 if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID) 55 if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID)
63 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(AbortError, "Operation failed - not a valid registration object")); 56 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(AbortError, "Operation failed - not a valid registration object"));
64 57
65 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ; 58 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
66 ScriptPromise promise = resolver->promise(); 59 ScriptPromise promise = resolver->promise();
67 60
(...skipping 20 matching lines...) Expand all
88 81
89 return promise; 82 return promise;
90 } 83 }
91 84
92 DEFINE_TRACE(SyncRegistration) 85 DEFINE_TRACE(SyncRegistration)
93 { 86 {
94 visitor->trace(m_serviceWorkerRegistration); 87 visitor->trace(m_serviceWorkerRegistration);
95 } 88 }
96 89
97 } // namespace blink 90 } // namespace blink
OLDNEW
« no previous file with comments | « Source/modules/background_sync/PeriodicSyncRegistration.cpp ('k') | public/platform/modules/background_sync/WebSyncProvider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698