Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(413)

Side by Side Diff: Source/modules/background_sync/PeriodicSyncRegistration.cpp

Issue 1288893004: Revert of Reland Call dispatcher's releaseRegistration when done with registrations (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | Source/modules/background_sync/SyncRegistration.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "config.h" 5 #include "config.h"
6 #include "modules/background_sync/PeriodicSyncRegistration.h" 6 #include "modules/background_sync/PeriodicSyncRegistration.h"
7 7
8 #include "bindings/core/v8/CallbackPromiseAdapter.h" 8 #include "bindings/core/v8/CallbackPromiseAdapter.h"
9 #include "bindings/core/v8/ScriptPromiseResolver.h" 9 #include "bindings/core/v8/ScriptPromiseResolver.h"
10 #include "core/dom/DOMException.h" 10 #include "core/dom/DOMException.h"
(...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 , m_minPeriod(options.minPeriod()) 59 , m_minPeriod(options.minPeriod())
60 , m_networkState(options.networkState()) 60 , m_networkState(options.networkState())
61 , m_powerState(options.powerState()) 61 , m_powerState(options.powerState())
62 , m_tag(options.tag()) 62 , m_tag(options.tag())
63 , m_serviceWorkerRegistration(serviceWorkerRegistration) 63 , m_serviceWorkerRegistration(serviceWorkerRegistration)
64 { 64 {
65 } 65 }
66 66
67 PeriodicSyncRegistration::~PeriodicSyncRegistration() 67 PeriodicSyncRegistration::~PeriodicSyncRegistration()
68 { 68 {
69 Platform* currentPlatform = Platform::current();
70 if (!currentPlatform)
71 return;
72 WebSyncProvider* syncProvider = currentPlatform->backgroundSyncProvider();
73 if (!syncProvider)
74 return;
75 syncProvider->releaseRegistration(m_id);
76 } 69 }
77 70
78 ScriptPromise PeriodicSyncRegistration::unregister(ScriptState* scriptState) 71 ScriptPromise PeriodicSyncRegistration::unregister(ScriptState* scriptState)
79 { 72 {
80 if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID) 73 if (m_id == WebSyncRegistration::UNREGISTERED_SYNC_ID)
81 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(AbortError, "Operation failed - not a valid registration object")); 74 return ScriptPromise::rejectWithDOMException(scriptState, DOMException:: create(AbortError, "Operation failed - not a valid registration object"));
82 75
83 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ; 76 ScriptPromiseResolver* resolver = ScriptPromiseResolver::create(scriptState) ;
84 ScriptPromise promise = resolver->promise(); 77 ScriptPromise promise = resolver->promise();
85 78
86 WebSyncProvider* webSyncProvider = Platform::current()->backgroundSyncProvid er(); 79 WebSyncProvider* webSyncProvider = Platform::current()->backgroundSyncProvid er();
87 ASSERT(webSyncProvider); 80 ASSERT(webSyncProvider);
88 81
89 webSyncProvider->unregisterBackgroundSync(WebSyncRegistration::PeriodicityPe riodic, m_id, m_tag, m_serviceWorkerRegistration->webRegistration(), new SyncUnr egistrationCallbacks(resolver, m_serviceWorkerRegistration)); 82 webSyncProvider->unregisterBackgroundSync(WebSyncRegistration::PeriodicityPe riodic, m_id, m_tag, m_serviceWorkerRegistration->webRegistration(), new SyncUnr egistrationCallbacks(resolver, m_serviceWorkerRegistration));
90 83
91 return promise; 84 return promise;
92 } 85 }
93 86
94 DEFINE_TRACE(PeriodicSyncRegistration) 87 DEFINE_TRACE(PeriodicSyncRegistration)
95 { 88 {
96 visitor->trace(m_serviceWorkerRegistration); 89 visitor->trace(m_serviceWorkerRegistration);
97 } 90 }
98 91
99 } // namespace blink 92 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | Source/modules/background_sync/SyncRegistration.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698