chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js - Issue 1288043002: Fix ChromeVox next tests that passed without actually running.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

Issue 1288043002: Fix ChromeVox next tests that passed without actually running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Leave some tests broken, makring with TODOs. They are actually broken. Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs ('k') | chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

index dd267a3ee59b243428459bb55321f68635f2e222..7d63b4a7ccd1259ff130c4e0aa9a0f882dbc9670 100644

--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js

@@ -423,7 +423,7 @@ Output.RULES = {

'@describe_index($indexInParent, $parentChildCount)'

paragraph: {

- speak: '$value'

+ speak: '$descendants'

popUpButton: {

speak: '$value $name $role @aria_has_popup ' +