Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1909)

Unified Diff: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js

Issue 1288043002: Fix ChromeVox next tests that passed without actually running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Leave some tests broken, makring with TODOs. They are actually broken. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
diff --git a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
index bf0f03babf9c89f1c2d514fbe24106be53e033ee..db99b8ca8518fabda2af5c0da61fe579f1e3f191 100644
--- a/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
+++ b/chrome/browser/resources/chromeos/chromevox/testing/chromevox_next_e2e_test_base.js
@@ -21,10 +21,15 @@ ChromeVoxNextE2ETest.prototype = {
__proto__: ChromeVoxE2ETest.prototype,
/**
- * Launches a new tab with the given document, and runs callback when a load
- * complete fires.
+ * Gets the desktop from the automation API and Launches a new tab with
+ * the given document, and runs |callback| when a load complete fires.
+ * Arranges to call |testDone()| after |callback| returns.
+ * NOTE: Callbacks creatd instide |opt_callback| must be wrapped with
+ * |this.newCallback| if passed to asynchonous calls. Otherwise, the test
+ * will be finished prematurely.
* @param {function() : void} doc Snippet wrapped inside of a function.
- * @param {function()} opt_callback Called once the document is ready.
+ * @param {function(chrome.automation.AutomationNode)} callback
+ * Called once the document is ready.
*/
runWithLoadedTree: function(doc, callback) {
callback = this.newCallback(callback);
« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698