Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Unified Diff: chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs

Issue 1288043002: Fix ChromeVox next tests that passed without actually running. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Leave some tests broken, makring with TODOs. They are actually broken. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
diff --git a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
index f14f64909f8efe8ded847d95951e0a3e58aeb08b..7e7f4806bff9443e9fbe559fbf7a0186b70274d4 100644
--- a/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
+++ b/chrome/browser/resources/chromeos/chromevox/cvox2/background/background_test.extjs
@@ -180,8 +180,8 @@ TEST_F('BackgroundTest', 'LiveRegionAddElement', function() {
function(rootNode) {
var go = rootNode.find({ role: chrome.automation.RoleType.button });
go.doDefault();
- cvox.ChromeVox.tts.expectSpeech('Hello, world', testDone);
- cvox.ChromeVox.tts.finishExpectations();
+ cvox.ChromeVox.tts.expectSpeech('Hello, world');
+ cvox.ChromeVox.tts.finishExpectations(this.newCallback());
}.bind(this));
});
@@ -201,11 +201,13 @@ TEST_F('BackgroundTest', 'LiveRegionRemoveElement', function() {
var go = rootNode.find({ role: chrome.automation.RoleType.button });
go.doDefault();
cvox.ChromeVox.tts.expectSpeech('removed:');
- cvox.ChromeVox.tts.expectSpeech('Hello, world', testDone);
- cvox.ChromeVox.tts.finishExpectations();
+ cvox.ChromeVox.tts.expectSpeech('Hello, world');
+ cvox.ChromeVox.tts.finishExpectations(this.newCallback());
}.bind(this));
});
+// TODO(plundblad): This test finishes prematurely and breaks if that gets
+// fixed.
TEST_F('BackgroundTest', 'ShowContextMenu', function() {
this.runWithLoadedTree('<a href="a">a</a>',
function(rootNode) {
@@ -219,6 +221,8 @@ TEST_F('BackgroundTest', 'ShowContextMenu', function() {
}.bind(this));
});
+// TODO(plundblad): This test finishes prematurely and breaks if that gets
+// fixed.
TEST_F('BackgroundTest', 'InitialFocus', function() {
this.runWithLoadedTree('<a href="a">a</a>',
function(rootNode) {
@@ -228,6 +232,8 @@ TEST_F('BackgroundTest', 'InitialFocus', function() {
}.bind(this));
});
+// TODO(plundblad): This test finishes prematurely and breaks if that gets
+// fixed.
TEST_F('BackgroundTest', 'AriaLabel', function() {
this.runWithLoadedTree('<a aria-label="foo" href="a">a</a>',
function(rootNode) {
« no previous file with comments | « no previous file | chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698