Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1287973003: Check for xfer barriers in GrBatch, auto-issue barriers in GrGpu (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt, egdaniel
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Check for xfer barriers in GrBatch, auto-issue barriers in GrGpu Committed: https://skia.googlesource.com/skia/+/cb02b38b2c48bfde333ce3c699dd0451e2d867fa

Patch Set 1 #

Patch Set 2 : whitespace fix #

Patch Set 3 : rebase #

Total comments: 2

Patch Set 4 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -169 lines) Patch
M include/gpu/GrXferProcessor.h View 3 chunks +11 lines, -11 lines 0 comments Download
M src/gpu/GrAAConvexPathRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrAADistanceFieldPathRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrAAHairLinePathRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrAtlasTextContext.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 3 chunks +1 line, -3 lines 0 comments Download
M src/gpu/GrCommandBuilder.cpp View 1 chunk +0 lines, -17 lines 0 comments Download
M src/gpu/GrDefaultPathRenderer.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrGpu.h View 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/GrGpu.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.cpp View 1 chunk +0 lines, -8 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 5 chunks +15 lines, -10 lines 0 comments Download
M src/gpu/GrPathRendering.h View 3 chunks +8 lines, -0 lines 0 comments Download
M src/gpu/GrPipeline.h View 1 3 chunks +35 lines, -2 lines 0 comments Download
M src/gpu/GrPipeline.cpp View 1 chunk +14 lines, -16 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/GrReorderCommandBuilder.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 4 chunks +1 line, -20 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 1 2 2 chunks +1 line, -5 lines 0 comments Download
M src/gpu/GrTessellatingPathRenderer.cpp View 1 chunk +1 line, -3 lines 0 comments Download
M src/gpu/GrTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/GrXferProcessor.cpp View 1 chunk +5 lines, -7 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAFillRectBatch.cpp View 1 2 3 2 chunks +3 lines, -3 lines 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrAAStrokeRectBatch.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/batches/GrBatch.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawAtlasBatch.cpp View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrDrawVerticesBatch.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/batches/GrRectBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/batches/GrRectBatch.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/batches/GrStrokeRectBatch.h View 1 chunk +5 lines, -4 lines 0 comments Download
M src/gpu/batches/GrTestBatch.h View 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/effects/GrCustomXfermode.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M src/gpu/effects/GrDashingEffect.cpp View 1 chunk +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M tests/GrPorterDuffTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
bsalomon
5 years, 4 months ago (2015-08-12 15:51:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287973003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287973003/20001
5 years, 4 months ago (2015-08-12 15:55:30 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 4 months ago (2015-08-12 15:55:31 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/1789)
5 years, 4 months ago (2015-08-12 15:56:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287973003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287973003/40001
5 years, 4 months ago (2015-08-12 16:02:31 UTC) #9
joshualitt
https://codereview.chromium.org/1287973003/diff/40001/src/gpu/batches/GrAAFillRectBatch.cpp File src/gpu/batches/GrAAFillRectBatch.cpp (left): https://codereview.chromium.org/1287973003/diff/40001/src/gpu/batches/GrAAFillRectBatch.cpp#oldcode134 src/gpu/batches/GrAAFillRectBatch.cpp:134: helper.issueDraw(batchTarget); is this intentional?
5 years, 4 months ago (2015-08-12 18:03:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1287973003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1287973003/60001
5 years, 4 months ago (2015-08-12 18:07:45 UTC) #12
joshualitt
On 2015/08/12 18:07:45, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 4 months ago (2015-08-12 18:08:20 UTC) #13
bsalomon
https://codereview.chromium.org/1287973003/diff/40001/src/gpu/batches/GrAAFillRectBatch.cpp File src/gpu/batches/GrAAFillRectBatch.cpp (left): https://codereview.chromium.org/1287973003/diff/40001/src/gpu/batches/GrAAFillRectBatch.cpp#oldcode134 src/gpu/batches/GrAAFillRectBatch.cpp:134: helper.issueDraw(batchTarget); On 2015/08/12 18:03:17, joshualitt wrote: > is this ...
5 years, 4 months ago (2015-08-12 18:09:05 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-12 18:14:56 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/cb02b38b2c48bfde333ce3c699dd0451e2d867fa

Powered by Google App Engine
This is Rietveld 408576698