src/gpu/GrCommandBuilder.h - Issue 1287973003: Check for xfer barriers in GrBatch, auto-issue barriers in GrGpu

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/GrCommandBuilder.h

Issue 1287973003: Check for xfer barriers in GrBatch, auto-issue barriers in GrGpu (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Address comment Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/gpu/GrCommandBuilder.h

diff --git a/src/gpu/GrCommandBuilder.h b/src/gpu/GrCommandBuilder.h

index 1b6d5e0a224c38baa9310e051b1c18952b91d074..15237fbf909c0bb9fcd495a103198d5e88e69397 100644

--- a/src/gpu/GrCommandBuilder.h

+++ b/src/gpu/GrCommandBuilder.h

@@ -28,7 +28,7 @@ public:

bool insideClip,

GrRenderTarget* renderTarget);

virtual Cmd* recordDiscard(GrRenderTarget*);

- virtual Cmd* recordDrawBatch(GrBatch*) = 0;

+ virtual Cmd* recordDrawBatch(GrBatch*, const GrCaps&) = 0;

virtual Cmd* recordStencilPath(const GrPipelineBuilder&,

const GrPathProcessor*,

const GrPath*,

@@ -56,7 +56,6 @@ public:

GrSurface* src,

const SkIRect& srcRect,

const SkIPoint& dstPoint);

- virtual Cmd* recordXferBarrierIfNecessary(const GrPipeline&, const GrCaps&);

protected:

typedef GrTargetCommands::DrawBatch DrawBatch;

@@ -66,7 +65,6 @@ protected:

typedef GrTargetCommands::Clear Clear;

typedef GrTargetCommands::ClearStencilClip ClearStencilClip;

typedef GrTargetCommands::CopySurface CopySurface;

- typedef GrTargetCommands::XferBarrier XferBarrier;

GrCommandBuilder(GrGpu* gpu) : fCommands(gpu) {}

« no previous file with comments | « src/gpu/GrBufferedDrawTarget.cpp ('k') | src/gpu/GrCommandBuilder.cpp » ('j') | no next file with comments »