Remove GURL::SchemeIsSecure().

Remove GURL::SchemeIsSecure().

BUG=362214
Committed: https://crrev.com/4f486f6f6a1e5a90e33beb9af6d0d253e775b437
Cr-Commit-Position: refs/heads/master@{#344043}

[lgarron, 2015-08-14 20:50:58]

Chris: Any preference for reviewers among thestig@, abarth@, and brettw@? (Maybe
not abarth@.) thestig@ reviewed https://codereview.chromium.org/1049953003 .

To be landed after https://crrev.com/1294713004
https://codereview.chromium.org/1288733003

Android doesn't use it anymore, although iOS also needs to remove two more calls
internally before this lands.

[palmer, 2015-08-14 23:37:56]

palmer@chromium.org changed reviewers:
+ palmer@chromium.org

[palmer, 2015-08-14 23:37:57]

LGTM. I'd ask thestig, perhaps.

[lgarron, 2015-08-14 23:39:30]

lgarron@chromium.org changed reviewers:
+ thestig@chromium.org
- palmer@chromium.org

[lgarron, 2015-08-14 23:39:30]

thestig@: It's your lucky day! With your LGTM, we can end the reign of
SchemeIsSecure()!

(plz review?)

[Lei Zhang, 2015-08-14 23:49:07]

On 2015/08/14 23:39:30, lgarron wrote:
> thestig@: It's your lucky day! With your LGTM, we can end the reign of
> SchemeIsSecure()!
> 
> (plz review?)

- Isn't there one more caller in net/base/sdch_manager.cc?
- Happy to approve, even though I'm not in any of the relevant OWNERS files.
Weird.

[lgarron, 2015-08-14 23:54:30]

On 2015/08/14 at 23:49:07, thestig wrote:
> On 2015/08/14 23:39:30, lgarron wrote:
> > thestig@: It's your lucky day! With your LGTM, we can end the reign of
> > SchemeIsSecure()!
> > 
> > (plz review?)
> 
> - Isn't there one more caller in net/base/sdch_manager.cc?
> - Happy to approve, even though I'm not in any of the relevant OWNERS files.
Weird.

- CLs are out for the remaining uses: https://crrev.com/1288733003 just landed
and https://codereview.chromium.org/1294713004 is ready. (I'm not crazy enough
to land them out of order, but I hope the CQ would also stop me if I tried. ;-)
- Hmm, interesting. Were you owner in April?

[Lei Zhang, 2015-08-14 23:56:42]

On 2015/08/14 23:54:30, lgarron wrote:
> - Hmm, interesting. Were you owner in April?

No, but lgtm!

[lgarron, 2015-08-14 23:56:58]

lgarron@chromium.org changed reviewers:
+ brettw@chromium.org, palmer@chromium.org
- thestig@chromium.org

[lgarron, 2015-08-14 23:56:58]

Oh, Chris used TBR on the other CL.
I'm sorry; you may not be able to help us end the reign. :-( But I hope it's
still your lucky day. :-)

brettw@: Join our quest! (Would you mind reviewing?)

[brettw, 2015-08-16 05:08:59]

lgtm

[lgarron, 2015-08-18 19:02:22]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-08-18 19:03:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287923004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287923004/1

[commit-bot: I haz the power, 2015-08-18 20:49:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 20:49:06]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lgarron, 2015-08-18 21:08:11]

The CQ bit was checked by lgarron@chromium.org

[commit-bot: I haz the power, 2015-08-18 21:09:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287923004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287923004/1

[commit-bot: I haz the power, 2015-08-18 21:57:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-18 21:58:13]

Patchset 1 (id:??) landed as
https://crrev.com/4f486f6f6a1e5a90e33beb9af6d0d253e775b437
Cr-Commit-Position: refs/heads/master@{#344043}