Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(656)

Issue 1288733003: Switch leftover data reduction proxy call from SchemeIsSecure() to SchemeIsCryptographic(). (Closed)

Created:
5 years, 4 months ago by lgarron
Modified:
5 years, 4 months ago
Reviewers:
sgurun-gerrit only
CC:
chromium-reviews, palmer
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch DataReductionProxyResourceThrottle::MaybeCreate() from SchemeIsSecure() to SchemeIsCryptographic(). BUG=362214 Committed: https://crrev.com/fc65f35f28fe5625306f40e80259fced9675a57e Cr-Commit-Position: refs/heads/master@{#343528}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/renderer_host/data_reduction_proxy_resource_throttle_android.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
lgarron
sgurun@: Could you review this change? It's the second-to-last remaining use of SchemeIsSecure(), which is ...
5 years, 4 months ago (2015-08-14 20:20:00 UTC) #2
lgarron
sgurun@: Could you review this change? It's the second-to-last remaining use of SchemeIsSecure(), which is ...
5 years, 4 months ago (2015-08-14 20:20:00 UTC) #3
sgurun-gerrit only
lgtm
5 years, 4 months ago (2015-08-14 22:47:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1288733003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1288733003/1
5 years, 4 months ago (2015-08-14 22:54:54 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 23:36:54 UTC) #7
commit-bot: I haz the power
5 years, 4 months ago (2015-08-14 23:37:46 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc65f35f28fe5625306f40e80259fced9675a57e
Cr-Commit-Position: refs/heads/master@{#343528}

Powered by Google App Engine
This is Rietveld 408576698