Issue 1049953003: Rename GURL::SchemeUsesTLS to SchemeIsCryptographic.

Issue 1049953003: Rename GURL::SchemeUsesTLS to SchemeIsCryptographic. (Closed)

Created:
5 years, 8 months ago by palmer

Modified:
5 years, 8 months ago

Reviewers:
Lei Zhang, brettw, Ilya Sherman, mmenke, abarth-chromium

CC:
chromium-reviews, tfarina, cbentzel+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Rename GURL::SchemeUsesTLS to SchemeIsCryptographic. Since there will increasingly be things like QUIC that offer similar guarantees but which are not precisely TLS. Per discussion in https://codereview.chromium.org/1049533002/. BUG=362214 TBR=brettw,thestig@chromium.org,isherman@chromium.org,mmenke@chromium.org,abarth@chromium.org Committed: https://crrev.com/12b415ba1a82e3c284a073637ae5221a2a948ede Cr-Commit-Position: refs/heads/master@{#326236}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -32 lines)			Patch
M	chrome/browser/captive_portal/captive_portal_tab_helper.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/captive_portal/captive_portal_tab_helper_unittest.cc	View	12 chunks	+23 lines, -16 lines	0 comments	Download
M	chrome/browser/net/certificate_error_reporter.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/origin_util.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/utility/importer/ie_importer_win.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/utility/importer/nss_decryptor.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	url/gurl.h	View	2 chunks	+9 lines, -8 lines	0 comments	Download

Total messages: 5 (1 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049953003/1

5 years, 8 months ago (2015-04-22 05:25:38 UTC) #2

commit-bot: I haz the power

5 years, 8 months ago (2015-04-22 06:35:13 UTC) #5

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/12b415ba1a82e3c284a073637ae5221a2a948ede
Cr-Commit-Position: refs/heads/master@{#326236}