Slimming Paint phase 2 compositing algorithm plumbing

Slimming Paint phase 2 compositing algorithm plumbing

This patch adds the plumbing for slimming paint phase 2's compositing
algorithm. The basic idea is to move compositing after painting. This
patch has the plumbing for two prerequesites to support that change:
1) A hook has been added so the merge algorithm can update a
DisplayItemDiff structure.
2) A step for property tree building has been added during the
compositing step.

The full design can be found at:
https://docs.google.com/document/d/1qF7wpO_lhuxUO6YXKZ3CJuXi0grcb5gKZJBBgnoTd0k/view

This patch is an updated version of Chrishtr's initial implementation
in https://codereview.chromium.org/1238123004 except the display list
API has not been implemented.

BUG=481592
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200612

[pdr., 2015-08-13 05:12:12]

pdr@chromium.org changed reviewers:
+ chrishtr@chromium.org, jbroman@chromium.org, wangxianzhu@chromium.org

[Xianzhu, 2015-08-13 17:03:58]

Previously I thought of making LayoutClean the last document cycle state,
because with interest rect we don't actually have PaintInvalidationClean and
CompositingClean states for the whole document. Now I think it's also looks good
to treat the two states as "clean for the last interest rect".

https://codereview.chromium.org/1287093004/diff/20001/Source/core/paint/Displ...
File Source/core/paint/DisplayItemListPaintTest.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/core/paint/Displ...
Source/core/paint/DisplayItemListPaintTest.cpp:115: #endif
Would the following work?

75s/EXPECT_DISPLAY_LIST/EXPECT_DISPLAY_LIST_BASE/

#ifndef NDEBUG
#define EXPECT_DISPLAY_LIST(actual, expectedSizeWithoutFill, ...) \
    EXPECT_DISPLAY_LIST_BASE( \
        actual, expectedSizeWithoutFill + 1, \
        TestDislayItem(layoutView().layer()->graphicsLayerBacking(),
DisplayItem::DebugRedFill); \
        __VA_ARGS__)
#else
#define EXPECT_DISPLAY_LIST EXPECT_DISPLAY_LIST_BASE
#endif

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:94: if
(m_painter->displayItemList()) {
Add DisplayItemList::appendToWebDisplayItemList() for v2?

[chrishtr, 2015-08-13 17:28:32]

https://codereview.chromium.org/1287093004/diff/20001/Source/core/compositing...
File Source/core/compositing/DisplayListCompositingBuilder.h (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilder.h:17:
DisplayListCompositingBuilder(const DisplayItemList& displayItemList, const
DisplayListDiff& displayListDiff, GraphicsLayer& rootGraphicsLayer)
GraphicsLayer is probably not going to be part of the new cc API. Instead it'll
maybe be a new kind of RenderSurfaceLayerList. Let's call it a
CompositedDisplayList.

So instead I suggest you define an object of type CompositedDisplayList or
similar, and have call sites pass a pointer to it to the build() function below.
CompositedDisplayList would be:

struct CompositedDisplayList {
  Vector<SimpleLayer*>
  DisplayItemTransformTree transformTree;
  .. (other trees)

  Vector<SimpleLayerInvalidations> simpleLayerInvalidations;
}

https://codereview.chromium.org/1287093004/diff/20001/Source/core/dom/Documen...
File Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/core/dom/Documen...
Source/core/dom/DocumentLifecycle.cpp:176: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled() && state ==
InPaintInvalidation)
Also add the paint lifecycle stage in this CL.

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:99: }
Maybe we should just skip this glue code, which is temporary anyway.

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/GraphicsLayer.h (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/GraphicsLayer.h:252: void
setTransformTree(PassOwnPtr<const DisplayItemTransformTree> transformTree) {
m_transformTree = transformTree; }
Revert changes to this class, per earlier comments.

[pdr., 2015-08-13 20:55:00]

Thx! PTAL

https://codereview.chromium.org/1287093004/diff/20001/Source/core/compositing...
File Source/core/compositing/DisplayListCompositingBuilder.h (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilder.h:17:
DisplayListCompositingBuilder(const DisplayItemList& displayItemList, const
DisplayListDiff& displayListDiff, GraphicsLayer& rootGraphicsLayer)
On 2015/08/13 at 17:28:31, chrishtr wrote:
> GraphicsLayer is probably not going to be part of the new cc API. Instead
it'll maybe be a new kind of RenderSurfaceLayerList. Let's call it a
CompositedDisplayList.
> 
> So instead I suggest you define an object of type CompositedDisplayList or
similar, and have call sites pass a pointer to it to the build() function below.
CompositedDisplayList would be:
> 
> struct CompositedDisplayList {
>   Vector<SimpleLayer*>
>   DisplayItemTransformTree transformTree;
>   .. (other trees)
> 
>   Vector<SimpleLayerInvalidations> simpleLayerInvalidations;
> }

Added CompositedDisplayList but, after implementing it, I'm not sure it actually
makes the code or api cleaner.

https://codereview.chromium.org/1287093004/diff/20001/Source/core/dom/Documen...
File Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/core/dom/Documen...
Source/core/dom/DocumentLifecycle.cpp:176: if
(RuntimeEnabledFeatures::slimmingPaintV2Enabled() && state ==
InPaintInvalidation)
On 2015/08/13 at 17:28:31, chrishtr wrote:
> Also add the paint lifecycle stage in this CL.

Done.

As discussed offline, it'll be difficult to do the spv2 transition reusing the
existing compositing lifecycle phase. We now have four new states for
InPaintForSlimmingPaintV2 and InCompositingForSlimmingPaintV2 (and *Clean
versions, respectively). Two phases are not strictly needed but I think they'll
become useful very soon.

https://codereview.chromium.org/1287093004/diff/20001/Source/core/paint/Displ...
File Source/core/paint/DisplayItemListPaintTest.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/core/paint/Displ...
Source/core/paint/DisplayItemListPaintTest.cpp:115: #endif
On 2015/08/13 at 17:03:58, Xianzhu wrote:
> Would the following work?
> 
> 75s/EXPECT_DISPLAY_LIST/EXPECT_DISPLAY_LIST_BASE/
> 
> #ifndef NDEBUG
> #define EXPECT_DISPLAY_LIST(actual, expectedSizeWithoutFill, ...) \
>     EXPECT_DISPLAY_LIST_BASE( \
>         actual, expectedSizeWithoutFill + 1, \
>         TestDislayItem(layoutView().layer()->graphicsLayerBacking(),
DisplayItem::DebugRedFill); \
>         __VA_ARGS__)
> #else
> #define EXPECT_DISPLAY_LIST EXPECT_DISPLAY_LIST_BASE
> #endif

Good idea, done.

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:94: if
(m_painter->displayItemList()) {
On 2015/08/13 at 17:03:58, Xianzhu wrote:
> Add DisplayItemList::appendToWebDisplayItemList() for v2?

I'm afraid I don't understand. Can you rephrase your question?

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:99: }
On 2015/08/13 at 17:28:32, chrishtr wrote:
> Maybe we should just skip this glue code, which is temporary anyway.

Added a comment that this code is temporary and just here to make the browser
usable. Without it, we'll crash due to committing new display items twice.

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/GraphicsLayer.h (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/GraphicsLayer.h:252: void
setTransformTree(PassOwnPtr<const DisplayItemTransformTree> transformTree) {
m_transformTree = transformTree; }
On 2015/08/13 at 17:28:32, chrishtr wrote:
> Revert changes to this class, per earlier comments.

These changes are needed for test coverage until we find a new home for the new
transform tree. I've added a comment that these will be moved.

[chrishtr, 2015-08-13 21:33:16]

https://codereview.chromium.org/1287093004/diff/40001/Source/core/compositing...
File Source/core/compositing/DisplayListCompositingBuilderTest.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilderTest.cpp:17: class
DisplayItemListCompositingBuilderTest : public RenderingTest {
Make two test class: this one, and one which directly unittests the inputs and
outputs of the builder. Rename this test class accordingly.

https://codereview.chromium.org/1287093004/diff/40001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilderTest.cpp:56:
setBodyInnerHTML("<style>* { margin: 0; padding: 0;}</style><div>A</div>");
Document (in RenderingTest.cpp) that setBodyInnerHTML runs a forced layout.

https://codereview.chromium.org/1287093004/diff/40001/Source/core/dom/Documen...
File Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/dom/Documen...
Source/core/dom/DocumentLifecycle.cpp:244: || (m_state ==
CompositingForSlimmingPaintV2Clean &&
RuntimeEnabledFeatures::slimmingPaintV2Enabled());
Also include CompositingForSlimmingPaintV2Clean.

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
Source/core/frame/FrameView.cpp:2451:
view->compositor()->updateIfNeededRecursive();
Change comment to say that this is just needed in SP v2 for temporary plumbing
purposes, but is always required for v1.

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
Source/core/frame/FrameView.cpp:2478: // For SlimmingPaintV2, we still need this
to set up the root layer(s).
Fix comment like above.

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
Source/core/frame/FrameView.cpp:2510: // TODO: Update callers to pass in the
interest rect.
TODO(pdr)

https://codereview.chromium.org/1287093004/diff/40001/Source/core/paint/Displ...
File Source/core/paint/DisplayItemListPaintTest.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/paint/Displ...
Source/core/paint/DisplayItemListPaintTest.cpp:108:
document().view()->updateAllLifecyclePhases();
Add new v2 tests rather than editing existing ones.

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:93: // TODO: Remove this when
slimming paint v2 is further along. This is only
TODO(pdr)

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
File Source/platform/graphics/GraphicsLayer.h (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
Source/platform/graphics/GraphicsLayer.h:252: void
setTransformTree(PassOwnPtr<const DisplayItemTransformTree> transformTree) {
m_transformTree = transformTree; }
Revert this file.

[pdr., 2015-08-14 00:10:29]

PTAL

https://codereview.chromium.org/1287093004/diff/40001/Source/core/compositing...
File Source/core/compositing/DisplayListCompositingBuilderTest.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilderTest.cpp:17: class
DisplayItemListCompositingBuilderTest : public RenderingTest {
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Make two test class: this one, and one which directly unittests the inputs and
outputs of the builder. Rename this test class accordingly.

Done

https://codereview.chromium.org/1287093004/diff/40001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilderTest.cpp:56:
setBodyInnerHTML("<style>* { margin: 0; padding: 0;}</style><div>A</div>");
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Document (in RenderingTest.cpp) that setBodyInnerHTML runs a forced layout.

Added some comments in LayoutTestHelper.h

https://codereview.chromium.org/1287093004/diff/40001/Source/core/dom/Documen...
File Source/core/dom/DocumentLifecycle.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/dom/Documen...
Source/core/dom/DocumentLifecycle.cpp:244: || (m_state ==
CompositingForSlimmingPaintV2Clean &&
RuntimeEnabledFeatures::slimmingPaintV2Enabled());
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Also include CompositingForSlimmingPaintV2Clean.

Done

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
File Source/core/frame/FrameView.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
Source/core/frame/FrameView.cpp:2451:
view->compositor()->updateIfNeededRecursive();
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Change comment to say that this is just needed in SP v2 for temporary plumbing
purposes, but is always required for v1.

Done

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
Source/core/frame/FrameView.cpp:2478: // For SlimmingPaintV2, we still need this
to set up the root layer(s).
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Fix comment like above.

Done

https://codereview.chromium.org/1287093004/diff/40001/Source/core/frame/Frame...
Source/core/frame/FrameView.cpp:2510: // TODO: Update callers to pass in the
interest rect.
On 2015/08/13 at 21:33:16, chrishtr wrote:
> TODO(pdr)

Done

https://codereview.chromium.org/1287093004/diff/40001/Source/core/paint/Displ...
File Source/core/paint/DisplayItemListPaintTest.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/core/paint/Displ...
Source/core/paint/DisplayItemListPaintTest.cpp:108:
document().view()->updateAllLifecyclePhases();
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Add new v2 tests rather than editing existing ones.

These edits aren't changes to the test, they are fallout from changing the
lifecycle when slimming paint v2 is enabled.

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:93: // TODO: Remove this when
slimming paint v2 is further along. This is only
On 2015/08/13 at 21:33:16, chrishtr wrote:
> TODO(pdr)

Done

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
File Source/platform/graphics/GraphicsLayer.h (right):

https://codereview.chromium.org/1287093004/diff/40001/Source/platform/graphic...
Source/platform/graphics/GraphicsLayer.h:252: void
setTransformTree(PassOwnPtr<const DisplayItemTransformTree> transformTree) {
m_transformTree = transformTree; }
On 2015/08/13 at 21:33:16, chrishtr wrote:
> Revert this file.

Done

[chrishtr, 2015-08-14 00:17:20]

https://codereview.chromium.org/1287093004/diff/60001/Source/core/compositing...
File Source/core/compositing/DisplayListCompositingBuilder.h (right):

https://codereview.chromium.org/1287093004/diff/60001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilder.h:26:
CompositedDisplayList build();
void build(CompositedDisplayList&)

https://codereview.chromium.org/1287093004/diff/60001/Source/core/layout/Layo...
File Source/core/layout/LayoutView.h (right):

https://codereview.chromium.org/1287093004/diff/60001/Source/core/layout/Layo...
Source/core/layout/LayoutView.h:192: void setTransformTree(PassOwnPtr<const
DisplayItemTransformTree> transformTree) { m_transformTree = transformTree; }
Lets move this to WebViewImpl.

https://codereview.chromium.org/1287093004/diff/60001/Source/core/paint/Displ...
File Source/core/paint/DisplayItemListPaintTest.cpp (left):

https://codereview.chromium.org/1287093004/diff/60001/Source/core/paint/Displ...
Source/core/paint/DisplayItemListPaintTest.cpp:94: DeprecatedPaintLayer&
rootLayer = *layoutView.layer();
Please make v1 and v2 versions of appropriate tests.

[Xianzhu, 2015-08-14 17:22:59]

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:94: if
(m_painter->displayItemList()) {
On 2015/08/13 20:55:00, pdr wrote:
> On 2015/08/13 at 17:03:58, Xianzhu wrote:
> > Add DisplayItemList::appendToWebDisplayItemList() for v2?
> 
> I'm afraid I don't understand. Can you rephrase your question?

I meant to extract line 95-96 as DisplayItemList::appendToWebDisplayItemList()
(which can be separated from
DisplayItemList::commitNewDisplayItemsAndAppendToWebDisplayItemList()). This
seems to be used by temporary code only for now, but will
DisplayListCompositingBuilder need this function?

[pdr., 2015-08-14 17:28:18]

https://codereview.chromium.org/1287093004/diff/60001/Source/core/compositing...
File Source/core/compositing/DisplayListCompositingBuilder.h (right):

https://codereview.chromium.org/1287093004/diff/60001/Source/core/compositing...
Source/core/compositing/DisplayListCompositingBuilder.h:26:
CompositedDisplayList build();
On 2015/08/14 at 00:17:19, chrishtr wrote:
> void build(CompositedDisplayList&)

Done

I also did some minor cleanup of this file: updated the CompositedDisplayList
comment and removed the currently unused m_displayListDiff (but kept the
argument since it forms the api).

https://codereview.chromium.org/1287093004/diff/60001/Source/core/paint/Displ...
File Source/core/paint/DisplayItemListPaintTest.cpp (left):

https://codereview.chromium.org/1287093004/diff/60001/Source/core/paint/Displ...
Source/core/paint/DisplayItemListPaintTest.cpp:94: DeprecatedPaintLayer&
rootLayer = *layoutView.layer();
On 2015/08/14 at 00:17:20, chrishtr wrote:
> Please make v1 and v2 versions of appropriate tests.

Good catch.

This was already made into a spv2-specific test in
https://codereview.chromium.org/1282713003 (subtree caching). To keep coverage
of both codepaths, I've added DisplayItemListPaintTestForSlimmingPaintV2 to this
class and added back the original tests before
https://codereview.chromium.org/1282713003 landed. The new
DisplayItemListPaintTestForSlimmingPaintV2 tests are now copies of the spv1
versions but updated for v2. I've kept these in the same file to share the
common testing macros and test display item code.

[chrishtr, 2015-08-14 17:40:26]

Looks good except for WebViewImpl part.

[chrishtr, 2015-08-14 22:12:10]

lgtm

https://codereview.chromium.org/1287093004/diff/80001/Source/core/layout/Layo...
File Source/core/layout/LayoutView.h (right):

https://codereview.chromium.org/1287093004/diff/80001/Source/core/layout/Layo...
Source/core/layout/LayoutView.h:243: OwnPtrWillBePersistent<const
DisplayItemTransformTree> m_transformTree;
Put the CompositedDisplayList here instead of just the transform tree.

[pdr., 2015-08-15 02:32:25]

The CQ bit was checked by pdr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-08-15 02:32:39]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287093004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287093004/120001

[commit-bot: I haz the power, 2015-08-15 02:34:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-15 02:34:47]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pdr., 2015-08-15 02:35:04]

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
File Source/platform/graphics/ContentLayerDelegate.cpp (right):

https://codereview.chromium.org/1287093004/diff/20001/Source/platform/graphic...
Source/platform/graphics/ContentLayerDelegate.cpp:94: if
(m_painter->displayItemList()) {
On 2015/08/14 at 17:22:59, Xianzhu wrote:
> On 2015/08/13 20:55:00, pdr wrote:
> > On 2015/08/13 at 17:03:58, Xianzhu wrote:
> > > Add DisplayItemList::appendToWebDisplayItemList() for v2?
> > 
> > I'm afraid I don't understand. Can you rephrase your question?
> 
> I meant to extract line 95-96 as DisplayItemList::appendToWebDisplayItemList()
(which can be separated from
DisplayItemList::commitNewDisplayItemsAndAppendToWebDisplayItemList()). This
seems to be used by temporary code only for now, but will
DisplayListCompositingBuilder need this function?

Ahh, good idea. I've separated this out as you suggested. We'll probably use it
in followup patches.

https://codereview.chromium.org/1287093004/diff/80001/Source/core/layout/Layo...
File Source/core/layout/LayoutView.h (right):

https://codereview.chromium.org/1287093004/diff/80001/Source/core/layout/Layo...
Source/core/layout/LayoutView.h:243: OwnPtrWillBePersistent<const
DisplayItemTransformTree> m_transformTree;
On 2015/08/14 at 22:12:10, chrishtr wrote:
> Put the CompositedDisplayList here instead of just the transform tree.

Done

[chrishtr, 2015-08-15 14:31:27]

lgtm

[pdr., 2015-08-15 16:54:41]

On 2015/08/15 at 14:31:27, chrishtr wrote:
> lgtm

Original test failures have been fixed (crbug.com/521230).

Landing via CQ.

[pdr., 2015-08-15 16:54:43]

The CQ bit was checked by pdr@chromium.org

[commit-bot: I haz the power, 2015-08-15 16:54:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287093004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287093004/120001

[commit-bot: I haz the power, 2015-08-15 16:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-15 16:57:06]

Try jobs failed on following builders:
  ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)

[pdr., 2015-08-15 20:16:07]

The CQ bit was checked by pdr@chromium.org

[pdr., 2015-08-15 20:16:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
chrishtr@chromium.org
Link to the patchset: https://codereview.chromium.org/1287093004/#ps140001
(title: "Rebase from space")

[commit-bot: I haz the power, 2015-08-15 20:16:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1287093004/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1287093004/140001

[commit-bot: I haz the power, 2015-08-15 21:29:38]

Committed patchset #8 (id:140001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200612