Slimming Paint phase 2 compositing algorithm plumbing

Source/platform/graphics/ContentLayerDelegate.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 72 matching lines @@
 }
 
 void ContentLayerDelegate::paintContents(
     WebDisplayItemList* webDisplayItemList, const WebRect& clip,
     WebContentLayerClient::PaintingControlSetting paintingControl)
 {
     TRACE_EVENT1("blink,benchmark", "ContentLayerDelegate::paintContents", "clip_rect", toTracedValue(clip));
 
     ASSERT(RuntimeEnabledFeatures::slimmingPaintEnabled());
 
+    if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+        if (m_painter->displayItemList()) {

[Xianzhu, 2015/08/13 17:03:58]

Add DisplayItemList::appendToWebDisplayItemList() for v2?

[pdr., 2015/08/13 20:55:00]

I'm afraid I don't understand. Can you rephrase your question?

[Xianzhu, 2015/08/14 17:22:59]

I meant to extract line 95-96 as DisplayItemList::appendToWebDisplayItemList()
(which can be separated from
DisplayItemList::commitNewDisplayItemsAndAppendToWebDisplayItemList()). This
seems to be used by temporary code only for now, but will
DisplayListCompositingBuilder need this function? 

[pdr., 2015/08/15 02:35:04]

Ahh, good idea. I've separated this out as you suggested. We'll probably use it
in followup patches.

+            for (auto& displayItem : m_painter->displayItemList()->displayItems())
+                displayItem.appendToWebDisplayItemList(webDisplayItemList);
+        }
+        return;
+    }

[chrishtr, 2015/08/13 17:28:32]

Maybe we should just skip this glue code, which is temporary anyway.

[pdr., 2015/08/13 20:55:00]

Added a comment that this code is temporary and just here to make the browser
usable. Without it, we'll crash due to committing new display items twice.

+
     DisplayItemList* displayItemList = m_painter->displayItemList();
     ASSERT(displayItemList);
     displayItemList->setDisplayItemConstructionIsDisabled(
         paintingControl == WebContentLayerClient::DisplayListConstructionDisabled);
 
     // We also disable caching when Painting or Construction are disabled. In both cases we would like
     // to compare assuming the full cost of recording, not the cost of re-using cached content.
     if (paintingControl != WebContentLayerClient::PaintDefaultBehavior)
         displayItemList->invalidateAll();
 
     GraphicsContext::DisabledMode disabledMode = GraphicsContext::NothingDisabled;
     if (paintingControl == WebContentLayerClient::DisplayListPaintingDisabled
         || paintingControl == WebContentLayerClient::DisplayListConstructionDisabled)
         disabledMode = GraphicsContext::FullyDisabled;
     GraphicsContext context(displayItemList, disabledMode);
 
     m_painter->paint(context, clip);
 
     displayItemList->commitNewDisplayItemsAndAppendToWebDisplayItemList(webDisplayItemList);
 }
 
 size_t ContentLayerDelegate::approximateUnsharedMemoryUsage() const
 {
     return m_painter->displayItemList()->approximateUnsharedMemoryUsage();
 }
 
 } // namespace blink