Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1300473002: MD Download: add "Nothing to see here..." empty downloads message (Closed)

Created:
5 years, 4 months ago by Dan Beam
Modified:
5 years, 4 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews, asanka, benjhayden+dwatch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Download: add "Nothing to see here..." empty downloads message BUG=520709 R=groby@chromium.org NOTRY=true Committed: https://crrev.com/922b990adb59701e2a090ff7039c4ce806c8573a Cr-Commit-Position: refs/heads/master@{#343826}

Patch Set 1 : less flicker? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M chrome/app/generated_resources.grd View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/resources/md_downloads/1x/no_downloads.png View Binary file 0 comments Download
A chrome/browser/resources/md_downloads/2x/no_downloads.png View Binary file 0 comments Download
M chrome/browser/resources/md_downloads/manager.css View 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 1 chunk +7 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 3 chunks +3 lines, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1287053004 Patch 1
Issue 1287053004 Patch 20001

Messages

Total messages: 17 (6 generated)
Dan Beam
5 years, 4 months ago (2015-08-15 00:16:28 UTC) #2
Dan Beam
screenshot: http://i.imgur.com/iwOaJEh.png
5 years, 4 months ago (2015-08-15 00:42:44 UTC) #3
Dan Beam
ping groby@
5 years, 4 months ago (2015-08-17 18:00:46 UTC) #4
groby-ooo-7-16
lgtm
5 years, 4 months ago (2015-08-17 20:58:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300473002/20001
5 years, 4 months ago (2015-08-17 21:04:53 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99262)
5 years, 4 months ago (2015-08-17 23:50:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300473002/20001
5 years, 4 months ago (2015-08-17 23:54:12 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99428)
5 years, 4 months ago (2015-08-18 02:05:55 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300473002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300473002/20001
5 years, 4 months ago (2015-08-18 03:30:42 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:20001)
5 years, 4 months ago (2015-08-18 05:25:19 UTC) #16
commit-bot: I haz the power
5 years, 4 months ago (2015-08-18 05:25:55 UTC) #17
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/922b990adb59701e2a090ff7039c4ce806c8573a
Cr-Commit-Position: refs/heads/master@{#343826}

Powered by Google App Engine
This is Rietveld 408576698