DCHECK_IS_ON needs ()'s

DCHECK_IS_ON needs ()

Found in the course of reintroducing this bug elsewhere

R=danakj@chromium.org, mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/ad09fd1bc818ab0579daf7b0e5cc7b2b20225975

[ncarter (slow), 2015-08-12 20:54:24]

nick@chromium.org changed reviewers:
+ rsesek@chromium.org

[ncarter (slow), 2015-08-12 20:54:32]

rsesek: ptal

[Mark Mentovai, 2015-08-12 21:00:27]

mark@chromium.org changed reviewers:
+ mark@chromium.org

[Mark Mentovai, 2015-08-12 21:00:27]

DCHECK_IS_ON appears elsewhere in the Crashpad codebase. Can you fix all of
them?

[ncarter (slow), 2015-08-12 23:35:21]

Good catch. Fixed all the places! (I'd only seen the one because my regex was
DCHECK_IS_ON[^(], not DCHECK_IS_ON$)

[ncarter (slow), 2015-08-12 23:39:33]

and btw:the old behavior 

#if DCHECK_IS_ON 

Was always false. I verified this by adding #errors. I've verified that chrome
mac still builds with this change, and that crashpad_test_test passes.

[ncarter (slow), 2015-08-12 23:50:14]

+danakj (as an fyi)

I'm going on vacation starting in ten minutes, so y'all should feel free to cq
this or take it over.

[danakj, 2015-08-13 00:06:34]

danakj@chromium.org changed reviewers:
+ danakj@chromium.org

[danakj, 2015-08-13 00:06:35]

LGTM

[Mark Mentovai, 2015-08-13 00:44:57]

LGTM

[Mark Mentovai, 2015-08-13 00:47:43]

Committed patchset #2 (id:20001) manually as
ad09fd1bc818ab0579daf7b0e5cc7b2b20225975 (presubmit successful).

[Mark Mentovai, 2015-08-13 00:50:55]

Thanks for the patch, Nick. Have a great vacation!