Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: util/misc/initialization_state_dcheck.h

Issue 1287043005: DCHECK_IS_ON needs ()'s (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad.git@master
Patch Set: Fix all the places Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | util/misc/initialization_state_dcheck.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: util/misc/initialization_state_dcheck.h
diff --git a/util/misc/initialization_state_dcheck.h b/util/misc/initialization_state_dcheck.h
index 790a3d8cf75948675d783bc94d209fbeb0812c83..24b3d077d8595e010a3b12e2ea8b9cc1a6f6bd0c 100644
--- a/util/misc/initialization_state_dcheck.h
+++ b/util/misc/initialization_state_dcheck.h
@@ -25,7 +25,7 @@
namespace crashpad {
-#if DCHECK_IS_ON || DOXYGEN
+#if DCHECK_IS_ON() || DOXYGEN
//! \brief Tracks whether data are initialized, triggering a DCHECK assertion
//! on an invalid data access.
@@ -168,7 +168,7 @@ struct InitializationStateDcheck {
// technically invalid according to the standard, but clang and g++ accept them
// without complaint even with warnings turned up. They take up no space at all,
// and they can be “initialized” with the same () syntax used to initialize
-// objects of the DCHECK_IS_ON InitializationStateDcheck class above.
+// objects of the DCHECK_IS_ON() InitializationStateDcheck class above.
using InitializationStateDcheck = bool[0];
#endif // COMPILER_MSVC
« no previous file with comments | « client/simple_string_dictionary_test.cc ('k') | util/misc/initialization_state_dcheck.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698