client/simple_string_dictionary_test.cc - Issue 1287043005: DCHECK_IS_ON needs ()'s

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: client/simple_string_dictionary_test.cc

Issue 1287043005: DCHECK_IS_ON needs ()'s (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad.git@master

Patch Set: Fix all the places Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: client/simple_string_dictionary_test.cc

diff --git a/client/simple_string_dictionary_test.cc b/client/simple_string_dictionary_test.cc

index f1e3401361567edc8c56aefbeac0ee86605b084b..4619be742bf87bea84f8c24368c917707b045663 100644

--- a/client/simple_string_dictionary_test.cc

+++ b/client/simple_string_dictionary_test.cc

@@ -276,7 +276,7 @@ TEST(SimpleStringDictionary, OutOfSpace) {

EXPECT_FALSE(map.GetValueForKey("c"));

}

-#if DCHECK_IS_ON

+#if DCHECK_IS_ON()

TEST(SimpleStringDictionaryDeathTest, NullKey) {

TSimpleStringDictionary<4, 6, 6> map;

« no previous file with comments | « no previous file | util/misc/initialization_state_dcheck.h » ('j') | no next file with comments »