Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(481)

Issue 1286903003: Fix webp compile warnings on windows (Closed)

Created:
5 years, 4 months ago by msarett
Modified:
5 years, 4 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix webp compile warnings on windows This fix was landed with: https://codereview.chromium.org/1280073002/ The above CL was reverted due to an unrelated bug in libwebp. The above CL contains multiple components, and I think that reverting this part of the change was unintentional. BUG=skia: Committed: https://skia.googlesource.com/skia/+/340f3074b49de089e7e8cf9495fd54f67b7f9b8a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M third_party/libwebp/webp/config.h View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 7 (2 generated)
msarett
Noel, let me know if this fixes the compile issues that you've run into.
5 years, 4 months ago (2015-08-17 13:55:49 UTC) #2
djsollen
lgtm
5 years, 4 months ago (2015-08-17 14:05:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1286903003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1286903003/1
5 years, 4 months ago (2015-08-17 14:43:23 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/340f3074b49de089e7e8cf9495fd54f67b7f9b8a
5 years, 4 months ago (2015-08-17 14:49:40 UTC) #6
Noel Gordon
5 years, 4 months ago (2015-08-18 03:03:20 UTC) #7
On 2015/08/17 13:55:49, msarett wrote:
> Noel, let me know if this fixes the compile issues that you've run into.

Yes that fixed the webp compile issue on WIN32, thank you.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698