Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 1280073002: Update libwebp and resume testing scaled webp (Closed)

Created:
5 years, 4 months ago by scroggo_chromium
Modified:
5 years, 2 months ago
Reviewers:
msarett, jzern, scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Update libwebp and resume testing scaled webp libwebp has a fix for [1]. Update to the commit that contains the fix. Update libwebp.gypi, corresponding to libwebp's latest makefile. Turn back on DM testing for scaled webp, now that it should no longer use uninitialized memory. [1] https://code.google.com/p/webp/issues/detail?id=254 BUG=skia:4038 Committed: https://skia.googlesource.com/skia/+/0575d3e6c272744a66ab3281f9871366717df339 Committed: https://skia.googlesource.com/skia/+/f174e928732d69a0884d07168862265a97da10d8

Patch Set 1 #

Total comments: 2

Patch Set 2 : Why compile a file twice when once is better? #

Patch Set 3 : Do not build neon when not supported #

Patch Set 4 : rebase #

Patch Set 5 : Update to a newer version of libwebp with another uninitialized fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -7 lines) Patch
M DEPS View 1 2 3 4 1 chunk +2 lines, -1 line 0 comments Download
M dm/DM.cpp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M gyp/libwebp.gyp View 1 2 5 chunks +51 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (8 generated)
scroggo_chromium
https://codereview.chromium.org/1280073002/diff/1/DEPS File DEPS (right): https://codereview.chromium.org/1280073002/diff/1/DEPS#newcode18 DEPS:18: "third_party/externals/libwebp" : "https://chromium.googlesource.com/webm/libwebp.git@7df93893dcb73dc45733ab4518ce5ca322c25680", Derek, I know we usually like ...
5 years, 4 months ago (2015-08-07 16:14:10 UTC) #2
msarett
lgtm
5 years, 4 months ago (2015-08-07 16:20:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280073002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280073002/1
5 years, 4 months ago (2015-08-07 17:21:46 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/839) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, ...
5 years, 4 months ago (2015-08-07 17:22:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280073002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280073002/20001
5 years, 4 months ago (2015-08-07 19:41:41 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/0575d3e6c272744a66ab3281f9871366717df339
5 years, 4 months ago (2015-08-07 19:49:18 UTC) #11
scroggo
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/1278173004/ by scroggo@google.com. ...
5 years, 4 months ago (2015-08-07 19:53:08 UTC) #12
jzern
On 2015/08/07 19:49:18, commit-bot: I haz the power wrote: > Committed patchset #2 (id:20001) as ...
5 years, 4 months ago (2015-08-07 19:53:54 UTC) #13
scroggo
On 2015/08/07 19:53:54, jzern wrote: > On 2015/08/07 19:49:18, commit-bot: I haz the power wrote: ...
5 years, 4 months ago (2015-08-07 20:09:31 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1280073002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1280073002/80001
5 years, 2 months ago (2015-10-01 17:49:42 UTC) #18
commit-bot: I haz the power
5 years, 2 months ago (2015-10-01 17:56:12 UTC) #19
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/f174e928732d69a0884d07168862265a97da10d8

Powered by Google App Engine
This is Rietveld 408576698