Issue 12867002: Fixed two register allocator bugs (off-by-one error/failure propagation).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12867002: Fixed two register allocator bugs (off-by-one error/failure propagation). (Closed)

Created:
7 years, 9 months ago by Sven Panne

Modified:
7 years, 9 months ago

Reviewers:
Vyacheslav Egorov (Chromium), danno

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Fixed two register allocator bugs (off-by-one error/failure propagation). Minor cleanups on the way, e.g. making sure that we never use something after an allocation failed. Style question: Should we switch to some kind of MUST_USE_RESULT-style to ensure that we handle failures consistently? Not sure... BUG=v8:2576 Committed: http://code.google.com/p/v8/source/detail?r=13946

Patch Set 1 #

Patch Set 2 : Fixed typo on ARM #

Patch Set 3 : Fixed MIPS #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -13 lines)			Patch
M	src/arm/lithium-arm.cc	View	1	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-ia32.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	src/lithium-allocator.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/lithium-allocator.cc	View		6 chunks	+8 lines, -2 lines	0 comments	Download
M	src/mips/lithium-mips.cc	View	1 2	1 chunk	+6 lines, -2 lines	0 comments	Download
M	src/x64/lithium-x64.cc	View		1 chunk	+6 lines, -2 lines	0 comments	Download
M	test/cctest/test-heap-profiler.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

Slava: PTAL if you like, if not, it is OK, too. The fix is relatively ...

7 years, 9 months ago (2013-03-14 14:27:43 UTC) #1

Sven Panne

7 years, 9 months ago (2013-03-14 14:42:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r13946 (presubmit successful).

Expand Messages | Collapse Messages