Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Side by Side Diff: src/x64/lithium-x64.cc

Issue 12867002: Fixed two register allocator bugs (off-by-one error/failure propagation). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Fixed MIPS Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 665 matching lines...) Expand 10 before | Expand all | Expand 10 after
676 LInstruction* LChunkBuilder::AssignPointerMap(LInstruction* instr) { 676 LInstruction* LChunkBuilder::AssignPointerMap(LInstruction* instr) {
677 ASSERT(!instr->HasPointerMap()); 677 ASSERT(!instr->HasPointerMap());
678 instr->set_pointer_map(new(zone()) LPointerMap(position_, zone())); 678 instr->set_pointer_map(new(zone()) LPointerMap(position_, zone()));
679 return instr; 679 return instr;
680 } 680 }
681 681
682 682
683 LUnallocated* LChunkBuilder::TempRegister() { 683 LUnallocated* LChunkBuilder::TempRegister() {
684 LUnallocated* operand = 684 LUnallocated* operand =
685 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER); 685 new(zone()) LUnallocated(LUnallocated::MUST_HAVE_REGISTER);
686 operand->set_virtual_register(allocator_->GetVirtualRegister()); 686 int vreg = allocator_->GetVirtualRegister();
687 if (!allocator_->AllocationOk()) Abort("Not enough virtual registers."); 687 if (!allocator_->AllocationOk()) {
688 Abort("Out of virtual registers while trying to allocate temp register.");
689 return NULL;
690 }
691 operand->set_virtual_register(vreg);
688 return operand; 692 return operand;
689 } 693 }
690 694
691 695
692 LOperand* LChunkBuilder::FixedTemp(Register reg) { 696 LOperand* LChunkBuilder::FixedTemp(Register reg) {
693 LUnallocated* operand = ToUnallocated(reg); 697 LUnallocated* operand = ToUnallocated(reg);
694 ASSERT(operand->HasFixedPolicy()); 698 ASSERT(operand->HasFixedPolicy());
695 return operand; 699 return operand;
696 } 700 }
697 701
(...skipping 1748 matching lines...) Expand 10 before | Expand all | Expand 10 after
2446 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) { 2450 LInstruction* LChunkBuilder::DoLoadFieldByIndex(HLoadFieldByIndex* instr) {
2447 LOperand* object = UseRegister(instr->object()); 2451 LOperand* object = UseRegister(instr->object());
2448 LOperand* index = UseTempRegister(instr->index()); 2452 LOperand* index = UseTempRegister(instr->index());
2449 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index)); 2453 return DefineSameAsFirst(new(zone()) LLoadFieldByIndex(object, index));
2450 } 2454 }
2451 2455
2452 2456
2453 } } // namespace v8::internal 2457 } } // namespace v8::internal
2454 2458
2455 #endif // V8_TARGET_ARCH_X64 2459 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/mips/lithium-mips.cc ('k') | test/cctest/test-heap-profiler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698